Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bug: infinite redirect #211

Closed
SgtPooki opened this issue Apr 22, 2024 · 3 comments · Fixed by #215
Closed

bug: infinite redirect #211

SgtPooki opened this issue Apr 22, 2024 · 3 comments · Fixed by #215
Assignees
Labels
bug Something isn't working
Milestone

Comments

@SgtPooki
Copy link
Member

on first-hit:

https://inbrowser.dev/ipns/app.keom.io
https://inbrowser.dev/ipns/vitalik.eth
https://inbrowser.dev/ipfs/bafkqabtimvwgy3yk // "hello" inline CID

@SgtPooki SgtPooki added this to the Alpha milestone Apr 22, 2024
@SgtPooki SgtPooki self-assigned this Apr 22, 2024
@lidel
Copy link
Member

lidel commented Apr 23, 2024

Did some digging, was able to gather some useful info if network speed is throttled to 3G.

Opening https://inbrowser.dev/?helia-sw=/ipns/docs.ipfs.tech redirects (via JS?) to https://inbrowser.dev/ipns/docs.ipfs.tech which returns HTTP 302 to ?helia-sw=/ipns/docs.ipfs.tech and that creates infinite loop.

Need to confirm if this happends on localhost. If not, then it is specific to Cloudflare migration.

2024-04-23-161046_811x180_scrot

2024-04-23-161106_747x217_scrot

@lidel lidel added the bug Something isn't working label Apr 23, 2024
@SgtPooki SgtPooki linked a pull request Apr 23, 2024 that will close this issue
3 tasks
@SgtPooki
Copy link
Member Author

I believe it was a race condition with the server redirects & the js code that redirects. fixed by #215, and confirmed via "local inbrowser.tld" in e2e tests.

@SgtPooki
Copy link
Member Author

confirmed infinite redirect is resolved on inbrowser.dev with the deployment from https://github.com/ipfs-shipyard/service-worker-gateway/actions/runs/8805218177

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants