Added Default logic to refs #2678
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -50,7 +50,7 @@ NOTE: List all references recursively by using the flag '-r'. | |||
| cmds.StringArg("ipfs-path", true, true, "Path to the object(s) to list refs from.").EnableStdin(), | |||
| }, | |||
| Options: []cmds.Option{ | |||
| cmds.StringOption("format", "Emit edges with given format. Available tokens: <src> <dst> <linkname>."), | |||
| cmds.StringOption("format", "Emit edges with given format. Available tokens: <src> <dst> <linkname>.").Default("refs"), | |||
There was a problem hiding this comment.
This is wrong.
It should be <dst>.
RichardLitt
force-pushed
the
feature/add-default-to-refs
branch
from
3946a96 to
2fb0e23
Compare
|
LGTM |
| @@ -313,6 +313,8 @@ func (rw *RefWriter) WriteEdge(from, to key.Key, linkname string) error { | |||
|
|
|||
| var s string | |||
| switch { | |||
| case rw.PrintFmt == "<dst>": | |||
There was a problem hiding this comment.
I don't think this case is actually needed, the next case will do what youre doing here already
There was a problem hiding this comment.
It might be a simple (possibly premature) optimization.
99% of uses of this command will use this format string.
There was a problem hiding this comment.
That was my thinking: is this a premature opt?
There was a problem hiding this comment.
yeah, i'd call this a premature op. The added time of going through the other case will be dwarfed by the cost of a b58 marshal and api latency
Not sure about the switch statement. There may be a more elegant solution. Part of #2484 License: MIT Signed-off-by: Richard Littauer <richard.littauer@gmail.com>
RichardLitt
force-pushed
the
feature/add-default-to-refs
branch
from
2fb0e23 to
90421f5
Compare
RichardLitt
added
topic/docs-ipfs
|
Fixed. |
12 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Not sure about the switch statement. There may be a more elegant solution.
Part of #2484
License: MIT
Signed-off-by: Richard Littauer richard.littauer@gmail.com