Added Defaults to ipfs daemon
#2652
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| cmds.BoolOption(enableGCKwd, "Enable automatic periodic repo garbage collection"), | ||
| cmds.BoolOption(adjustFDLimitKwd, "Check and raise file descriptor limits if needed"), | ||
| cmds.BoolOption(initOptionKwd, "Initialize IPFS with default settings if not already initialized").Default(false), | ||
| cmds.StringOption(routingOptionKwd, "Overrides the routing option (dht, supernode)").Default("supernode"), |
There was a problem hiding this comment.
the default is not supernode, lol
There was a problem hiding this comment.
What does 'supernode' mean here, then? I haven't run across this term before.
There was a problem hiding this comment.
it was an old bit of code we wrote to be a 'centralized' routing system. We kindof abandoned it. The code might still work, but its not used.
There was a problem hiding this comment.
Ok, removed. We should remove that old code, then, too.
RichardLitt
force-pushed
the
feature/add-defaults-to-daemon
branch
from
0820ce3 to
6e91bc5
Compare
Split from #2484. License: MIT Signed-off-by: Richard Littauer <richard.littauer@gmail.com>
RichardLitt
force-pushed
the
feature/add-defaults-to-daemon
branch
from
6e91bc5 to
fa1c555
Compare
RichardLitt
added
need/review
|
LGTM |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Split from #2484.
License: MIT
Signed-off-by: Richard Littauer richard.littauer@gmail.com