Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

t0170 misc fixes #2638

Merged
merged 2 commits into from
May 9, 2016
Merged

t0170 misc fixes #2638

merged 2 commits into from
May 9, 2016

Conversation

chriscool
Copy link
Contributor

Here are a few cleanups or small fixes in t0170-dht.sh.

chriscool added 2 commits May 7, 2016 09:37
@chriscool
t0170: put startup_cluster() call outside test_expect_success
01bf209 
startup_cluster() already contains some test_expect_success, so
it should not be inside one.

License: MIT
Signed-off-by: Christian Couder <chriscool@tuxfamily.org>
@chriscool
t0170: remove useless 'echo' and add '&&'
e8bc591 
License: MIT
Signed-off-by: Christian Couder <chriscool@tuxfamily.org>
@chriscool
Copy link
Contributor Author

There is this failure in a TravisCI build:

�[36mexpecting success: 
  ipfsi 3 dht query banana >actual &&
  ipfsi 3 dht query apple >>actual &&
  ipfsi 3 dht query pear >>actual &&
  PEERS=$(wc -l actual | cut -d ' ' -f 1) &&
  [ -s actual ] ||
    test_fsh cat actual
�(B�[m
> cat actual

�[1m�[31mnot ok 14 - query�(B�[m
#   
#     ipfsi 3 dht query banana >actual &&
#     ipfsi 3 dht query apple >>actual &&
#     ipfsi 3 dht query pear >>actual &&
#     PEERS=$(wc -l actual | cut -d ' ' -f 1) &&
#     [ -s actual ] ||
#       test_fsh cat actual
#

and this one on CircleCI:

# github.com/ipfs/go-ipfs/test/dependencies/iptb
test/dependencies/iptb/proc_unix.go:11: undefined: setupOpt
make: *** [test_go_expensive] Error 2

This last one is strange because test/dependencies/iptb has been removed in a previous commit.

hackergrrl
hackergrrl reviewed May 7, 2016
View reviewed changes
test/sharness/t0170-dht.sh
@@ -19,7 +20,7 @@ test_expect_success 'peer ids' '
# ipfs dht findpeer <peerID>
test_expect_success 'findpeer' '
ipfsi 1 dht findpeer $PEERID_0 | sort >actual &&
echo "$(ipfsi 0 id -f "<addrs>" | cut -d / -f 1-5 | sort >expected)"
ipfsi 0 id -f "<addrs>" | cut -d / -f 1-5 | sort >expected &&
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch :)

@whyrusleeping
Copy link
Member

@chriscool the CircleCI failure keeps happening. I have no idea why. The short term 'fix' is to do a rebuild without cache.

The travisCI failure is this test, i'm not sure why its failing but i did file an issue for it: #2620

@whyrusleeping whyrusleeping merged commit 2c8fdab into master May 9, 2016
@whyrusleeping whyrusleeping deleted the t0170-misc-fixes branch May 9, 2016 18:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@chriscool @whyrusleeping @hackergrrl