Clear progress bar on ipfs cat exit
#1516
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
License: MIT Signed-off-by: rht <rhtbot@gmail.com>
|
This LGTM. I'll try it on OSX. (wish we could test this sort of thing) thoughts @whyrusleeping ? |
|
this is a pattern i've been seeing more and more frequently, needing to capture the EOF 'event' of a reader and do something to it, whether its close the httpResponse and check for a trailer error, or clear a line of output... I wonder if theres a nice composition for that to happen 'generically'. Anyways, these changes look good to me, although i wish it was testable |
|
Ok I will put an asciinema as an evidence. But this only proves that it works on my terminal (urxvt, which emulates vt102). The chance is high on os x (iterm2 or terminal.app): https://en.wikipedia.org/wiki/ANSI_escape_code |
|
@rht that looks really nice :) 👍 |
jbenet
added a commit
that referenced
this pull request
Jul 28, 2015
Clear progress bar on `ipfs cat` exit
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Close #1345
like
ipfs add, but not wget/curl.