New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make sure to stop progressbar on exit #1347

Closed

rht wants to merge 1 commit into ipfs:master from rht:master

Contributor

rht commented Jun 9, 2015

Can't reproduce #1345. Maybe this will do?

progress bar sometimes lingers after exit

This could mean either the progress bar keeps adding up even after exit or it hangs there after exit.

(b) clear the line before

The line is to be cleared (with '\b') after exit? But the elapsed time is useful info.
curl/wget retains the progress stat.

GitCop commented Jun 9, 2015

There were the following issues with your Pull Request

Commit: c098cff
- Invalid signoff. Commit message must end with Licence: MIT
  Signed-off-by: .* <.*>

Guidelines are available at: https://github.com/ipfs/community/blob/master/docs/commit-message.md Your feedback on GitCop is welcome on the following issue: ipfs/infra#23

This message was auto-generated by https://gitcop.com

1 similar comment

GitCop commented Jun 9, 2015

There were the following issues with your Pull Request

Commit: c098cff
- Invalid signoff. Commit message must end with Licence: MIT
  Signed-off-by: .* <.*>

Guidelines are available at: https://github.com/ipfs/community/blob/master/docs/commit-message.md Your feedback on GitCop is welcome on the following issue: ipfs/infra#23

This message was auto-generated by https://gitcop.com

jbenet added the backlog label

rht force-pushed the master branch from c098cff to 232cfb6 Compare

June 9, 2015 09:33

GitCop commented Jun 9, 2015

There were the following issues with your Pull Request

Commit: 232cfb6
- Invalid signoff. Commit message must end with Licence: MIT
  Signed-off-by: .* <.*>

Guidelines are available at: https://github.com/ipfs/community/blob/master/docs/commit-message.md Your feedback on GitCop is welcome on the following issue: ipfs/infra#23

This message was auto-generated by https://gitcop.com

1 similar comment

GitCop commented Jun 9, 2015

There were the following issues with your Pull Request

Commit: 232cfb6
- Invalid signoff. Commit message must end with Licence: MIT
  Signed-off-by: .* <.*>

Guidelines are available at: https://github.com/ipfs/community/blob/master/docs/commit-message.md Your feedback on GitCop is welcome on the following issue: ipfs/infra#23

This message was auto-generated by https://gitcop.com


          Make sure to stop progressbar on exit

f26a546

License: MIT
Signed-off-by: rht <rudyht@gmail.com>

rht force-pushed the master branch from 232cfb6 to f26a546 Compare

June 9, 2015 12:04

GitCop commented Jun 9, 2015

There were the following issues with your Pull Request

Commit: f26a546
- Invalid signoff. Commit message must end with Licence: MIT
  Signed-off-by: .* <.*>

Guidelines are available at: https://github.com/ipfs/community/blob/master/docs/commit-message.md Your feedback on GitCop is welcome on the following issue: ipfs/infra#23

This message was auto-generated by https://gitcop.com

1 similar comment

GitCop commented Jun 9, 2015

There were the following issues with your Pull Request

Commit: f26a546
- Invalid signoff. Commit message must end with Licence: MIT
  Signed-off-by: .* <.*>

Guidelines are available at: https://github.com/ipfs/community/blob/master/docs/commit-message.md Your feedback on GitCop is welcome on the following issue: ipfs/infra#23

This message was auto-generated by https://gitcop.com

rht closed this

jbenet removed the backlog label

Contributor

chriscool commented Jun 9, 2015

It looks like there are problems with GitCop. First it should have accepted the commit as it looks like it has the right trailers. Also it sent 2 messages instead of one.

Contributor Author

rht commented Jun 9, 2015

Oh no worries, I mis-typed 'license' instead of 'licence'.

ipfsbot commented Jun 9, 2015

(Need to update gitcop)

Any idea why it's yelling 4 times?

ipfsbot commented Jun 9, 2015

Oh it should be License

Contributor

chriscool commented Jun 9, 2015

It looks like there were 3 different commits sent:

and it yelled 6 times (twice for each commit).

Contributor

chriscool commented Jun 9, 2015

Yeah "Licence" is UK English and "License" is US English.
On GitCop it suggests using "Licence" (maybe because Gary is English or living in UK) so I used "Licence" but yeah it should check for "License".

Contributor

chriscool commented Jun 9, 2015

I changed it to "License" in GitCop. Sorry @rht you will have to change your hook back.

Member

jbenet commented Jun 9, 2015

that was me in the ipfsbot disguise. (email routing fail)

Member

jbenet commented Jun 9, 2015

@chriscool any idea why GitCop yells four times instead of just one?

ipfsbot commented Jun 10, 2015

Ah looks like you resolved it thanks

—
Sent from Mailbox

On Tue, Jun 9, 2015 at 3:23 PM, Juan Batiz-Benet notifications@github.com
wrote:

@chriscool any idea why GitCop yells four times instead of just one?

Reply to this email directly or view it on GitHub:
#1347 (comment)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet