Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs(cli): name inspect --verify #10308

Merged
merged 3 commits into from
Jan 17, 2024
+3 −3
Merged

docs(cli): name inspect --verify #10308

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
6d5b0f4
docs(cli): name inspect --verify
lidel Jan 17, 2024
762b807
docs: improve helptext
lidel Jan 17, 2024
7b95a24
fix: test uses new copy
hacdias Jan 17, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion core/commands/name/name.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -245,7 +245,7 @@ Passing --verify will verify signature against provided public key.

if out.Validation == nil {
tw.Flush()
fmt.Fprintf(w, "\nThis record was not validated.\n")
fmt.Fprintf(w, "\nThis record was not verified. Pass '--verify k51...' to verify.\n")
} else {
tw.Flush()
fmt.Fprintf(w, "\nValidation results:\n")
Expand Down
4 changes: 2 additions & 2 deletions test/cli/name_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -172,7 +172,7 @@ func TestName(t *testing.T) {

res = node.PipeToIPFS(bytes.NewReader(record), "name", "inspect")
out := res.Stdout.String()
require.Contains(t, out, "This record was not validated.")
require.Contains(t, out, "This record was not verified.")
require.Contains(t, out, publishPath)
require.Contains(t, out, "30m")

Expand All @@ -198,7 +198,7 @@ func TestName(t *testing.T) {
t.Parallel()
res = node.PipeToIPFS(bytes.NewReader(record), "name", "inspect")
out := res.Stdout.String()
require.Contains(t, out, "This record was not validated.")
require.Contains(t, out, "This record was not verified.")
require.Contains(t, out, publishPath)
require.Contains(t, out, "30m")
require.Contains(t, out, "Signature Type: V1+V2")
Expand Down
Loading