Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ipfs pin update produces error #4999

Closed
reit-c opened this issue May 6, 2018 · 1 comment
Closed

ipfs pin update produces error #4999

reit-c opened this issue May 6, 2018 · 1 comment
Labels
kind/bug A bug in existing code (including security flaws)

Comments

@reit-c
Copy link

reit-c commented May 6, 2018

Version information:

go-ipfs version: 0.4.14-
Repo version: 6
System version: amd64/linux
Golang version: go1.10

Type:

Bug

Description:

When doing ipfs pin update this error reliably results:

goroutine 40 [running]:
runtime/debug.Stack(0xc420042180, 0x10df740, 0xc4204fe280)
	/usr/lib/go/src/runtime/debug/stack.go:24 +0xa7
runtime/debug.PrintStack()
	/usr/lib/go/src/runtime/debug/stack.go:16 +0x22
gx/ipfs/QmNiJuT8Ja3hMVpBHXv3Q6dwmperaQ6JjLtpMQgMCD7xvx/go-ipfs-util.ErrCast(0xc4204fe360, 0x110be00)
	/home/steb/projects/go/src/github.com/ipfs/distributions/dists/go-ipfs/gopath/src/gx/ipfs/QmNiJuT8Ja3hMVpBHXv3Q6dwmperaQ6JjLtpMQgMCD7xvx/go-ipfs-util/util.go:37 +0x20
github.com/ipfs/go-ipfs/core/commands.glob..func116(0x149a6e0, 0xc4204fe360, 0xc420185200, 0x10df740, 0xc4204fe280, 0xc42008ddf0)
	/home/steb/projects/go/src/github.com/ipfs/distributions/dists/go-ipfs/gopath/src/github.com/ipfs/go-ipfs/core/commands/pin.go:421 +0x19d
github.com/ipfs/go-ipfs/commands/legacy.(*MarshalerEncoder).Encode(0xc42000c6e0, 0x10df740, 0xc4204fe280, 0x0, 0x0)
	/home/steb/projects/go/src/github.com/ipfs/distributions/dists/go-ipfs/gopath/src/github.com/ipfs/go-ipfs/commands/legacy/legacy.go:35 +0x1d9
gx/ipfs/QmfAkMSt9Fwzk48QDJecPcwCUjnf2uG7MLnmCGTp4C6ouL/go-ipfs-cmds/cli.(*responseEmitter).Emit(0xc4205c3f80, 0x10df740, 0xc4204fe280, 0x0, 0x0)
	/home/steb/projects/go/src/github.com/ipfs/distributions/dists/go-ipfs/gopath/src/gx/ipfs/QmfAkMSt9Fwzk48QDJecPcwCUjnf2uG7MLnmCGTp4C6ouL/go-ipfs-cmds/cli/responseemitter.go:197 +0x390
gx/ipfs/QmfAkMSt9Fwzk48QDJecPcwCUjnf2uG7MLnmCGTp4C6ouL/go-ipfs-cmds.Copy(0x14931c0, 0xc4205c3f80, 0x1493d00, 0xc420046280, 0x0, 0x0)
	/home/steb/projects/go/src/github.com/ipfs/distributions/dists/go-ipfs/gopath/src/gx/ipfs/QmfAkMSt9Fwzk48QDJecPcwCUjnf2uG7MLnmCGTp4C6ouL/go-ipfs-cmds/responseemitter.go:75 +0x80
gx/ipfs/QmfAkMSt9Fwzk48QDJecPcwCUjnf2uG7MLnmCGTp4C6ouL/go-ipfs-cmds/http.(*client).Execute(0xc420597e40, 0xc4205c3ea0, 0x14931c0, 0xc4205c3f80, 0x147d8c0, 0xc420597e00, 0xb066ac, 0xc42001df80)
	/home/steb/projects/go/src/github.com/ipfs/distributions/dists/go-ipfs/gopath/src/gx/ipfs/QmfAkMSt9Fwzk48QDJecPcwCUjnf2uG7MLnmCGTp4C6ouL/go-ipfs-cmds/http/client.go:116 +0x1ad
gx/ipfs/QmfAkMSt9Fwzk48QDJecPcwCUjnf2uG7MLnmCGTp4C6ouL/go-ipfs-cmds/cli.Run.func4(0x7f31ca903020, 0xc420597e40, 0xc4205c3ea0, 0x14931c0, 0xc4205c3f80, 0x147d8c0, 0xc420597e00, 0xc4205c03c0)
	/home/steb/projects/go/src/github.com/ipfs/distributions/dists/go-ipfs/gopath/src/gx/ipfs/QmfAkMSt9Fwzk48QDJecPcwCUjnf2uG7MLnmCGTp4C6ouL/go-ipfs-cmds/cli/run.go:146 +0x70
created by gx/ipfs/QmfAkMSt9Fwzk48QDJecPcwCUjnf2uG7MLnmCGTp4C6ouL/go-ipfs-cmds/cli.Run
	/home/steb/projects/go/src/github.com/ipfs/distributions/dists/go-ipfs/gopath/src/gx/ipfs/QmfAkMSt9Fwzk48QDJecPcwCUjnf2uG7MLnmCGTp4C6ouL/go-ipfs-cmds/cli/run.go:145 +0x6ac
Error: cast error

Note that there is not nor has their ever been a user named 'steb' nor a directory at /home/steb on this computer.

Reproduction:

echo "File 1" > a
echo "File 2" > b
hasha=$(ipfs add -q a)
hashb=$(ipfs add --pin=false -q b)
ipfs pin update $hasha $hashb
@Kubuxu
Copy link
Member

Kubuxu commented May 7, 2018

@reit-c The /home/steb is just a directory of the one who built the current distribution of go-ipfs.

@Kubuxu Kubuxu added the kind/bug A bug in existing code (including security flaws) label May 7, 2018
Stebalien added a commit that referenced this issue Jul 20, 2018
@Stebalien
correctly handle the output of pin update
7e10585 
fixes #4999

License: MIT
Signed-off-by: Steven Allen <steven@stebalien.com>
Stebalien added a commit that referenced this issue Jul 20, 2018
@Stebalien
test pin update
b9989f8 
tests #4999 and #5264

License: MIT
Signed-off-by: Steven Allen <steven@stebalien.com>
Stebalien added a commit that referenced this issue Jul 25, 2018
@Stebalien
correctly handle the output of pin update
d9b3b7f 
fixes #4999

License: MIT
Signed-off-by: Steven Allen <steven@stebalien.com>
Stebalien added a commit that referenced this issue Jul 25, 2018
@Stebalien
test pin update
2b2fab9 
tests #4999 and #5264

License: MIT
Signed-off-by: Steven Allen <steven@stebalien.com>
Stebalien added a commit that referenced this issue Jul 29, 2018
@Stebalien
correctly handle the output of pin update
4db8b3c 
fixes #4999

License: MIT
Signed-off-by: Steven Allen <steven@stebalien.com>
Stebalien added a commit that referenced this issue Jul 29, 2018
@Stebalien
test pin update
9f6eef7 
tests #4999 and #5264

License: MIT
Signed-off-by: Steven Allen <steven@stebalien.com>
whyrusleeping pushed a commit that referenced this issue Jul 30, 2018
@Stebalien @whyrusleeping
test pin update
e51588e 
tests #4999 and #5264

License: MIT
Signed-off-by: Steven Allen <steven@stebalien.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
kind/bug A bug in existing code (including security flaws)
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@Kubuxu @reit-c