Skip to content

Commit

Permalink
don't load identity in offline mode (temp)
Browse files Browse the repository at this point in the history
**For now**, we don't need to load/parse the private key
(which causes a signficant delay in commands) when doing
things entirely offline. This may change, and in that case
the private key should be loaded on demand.
  • Loading branch information
jbenet authored and whyrusleeping committed Sep 25, 2014
1 parent 31f2509 commit 5a67cdf
Showing 1 changed file with 8 additions and 5 deletions.
13 changes: 8 additions & 5 deletions core/core.go
Original file line number Diff line number Diff line change
Expand Up @@ -74,11 +74,6 @@ func NewIpfsNode(cfg *config.Config, online bool) (*IpfsNode, error) {
return nil, err
}

local, err := initIdentity(cfg)
if err != nil {
return nil, err
}

peerstore := peer.NewPeerstore()

// FIXME(brian): This is a bit dangerous. If any of the vars declared in
Expand All @@ -90,12 +85,20 @@ func NewIpfsNode(cfg *config.Config, online bool) (*IpfsNode, error) {
// TODO: refactor so we can use IpfsRouting interface instead of being DHT-specific
route *dht.IpfsDHT
exchangeSession exchange.Interface
local *peer.Peer
)

if online {
// add protocol services here.
ctx := context.TODO() // derive this from a higher context.

// when not online, don't need to parse private keys (yet)
local, err := initIdentity(cfg)
if err != nil {
cancel()
return nil, err
}

dhtService := netservice.NewService(nil) // nil handler for now, need to patch it
exchangeService := netservice.NewService(nil) // nil handler for now, need to patch it

Expand Down

0 comments on commit 5a67cdf

Please sign in to comment.