Skip to content

Commit

Permalink
routing: return errors of GetValuesAsync
Browse files Browse the repository at this point in the history
  • Loading branch information
Mildred Ki'Lya committed Mar 7, 2017
1 parent b297a2d commit 18e8c41
Show file tree
Hide file tree
Showing 2 changed files with 2 additions and 0 deletions.
1 change: 1 addition & 0 deletions routing/mock/centralized_client.go
Original file line number Diff line number Diff line change
Expand Up @@ -82,6 +82,7 @@ func (c *client) GetValuesAsync(ctx context.Context, key string, count int) <-ch
data, err := c.GetValue(ctx, key)
if err != nil {
log.Debugf("GetValuesAsync error: %v", err)
res <- &routing.RecvdVal{Error: err}
} else {
res <- &routing.RecvdVal{
Val: data,
Expand Down
1 change: 1 addition & 0 deletions routing/offline/offline.go
Original file line number Diff line number Diff line change
Expand Up @@ -97,6 +97,7 @@ func (c *offlineRouting) GetValuesAsync(ctx context.Context, key string, _ int)
value, err := c.GetValue(ctx, key)
if err != nil {
log.Debugf("OfflineRouting.GetValuesAsync: %v", err)
res <- &routing.RecvdVal{Error: err}
} else {
res <- &routing.RecvdVal{
Val: value,
Expand Down

1 comment on commit 18e8c41

@GitCop
Copy link

@GitCop GitCop commented on 18e8c41 Mar 7, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There were the following issues with your Pull Request

We ask for a few features in the commit message for Open Source licensing hygiene and commit message clarity.
git commit --amend can often help you quickly improve the commit message.
Guidelines and a script are available to help in the long run.
Your feedback on GitCop is welcome on this issue.


This message was auto-generated by https://gitcop.com

Please sign in to comment.