Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: downgrade ky #451

Closed
wants to merge 17 commits into from
Closed

fix: downgrade ky #451

wants to merge 17 commits into from

Conversation

alanshaw
Copy link
Member

achingbrain and others added 17 commits January 29, 2020 16:36
@achingbrain
fix: only require http api client if it has not been specified
3a0f870 
If we configure which http api module to use, don't try to require
`ipfs-http-client`, because that then means the containing project
needs to specify a dependency on `ipfs-http-client` when the
containing project might actually be `ipfs-http-client`...
@achingbrain
chore: update bundle size
ad2e60d 
No idea why this is necessary
@achingbrain
fix: restore ipfs module default
1fd7dcb
@achingbrain
fix: specify peer deps as externals to not bundle them
da43d03
@achingbrain
fix: add ipfs to dev deps to fix tests
f010017
@achingbrain
fix: rmeove extra installs as ipfs is now a dev dep
43e01d8
@achingbrain
fix: only require if module has not been specified as option
13ced9c
@achingbrain
fix: typo
2fe63c2
@achingbrain
fix: use module name as that is what is overridden by webpack
784bccd
@achingbrain
fix: defer finding binary until spawn time
3d813a0
@achingbrain
fix: spin clause round and remove duplication
21bd28f
@achingbrain
fix: start with this.opts, then overrides, then options
5d77e03
@achingbrain
chore: revert merging opts
be018b5
@achingbrain
fix: remove default ipfsModule because it triggers requiring ipfs
769d624
@achingbrain
fix: do not send empty ipfsModule object to web api
21fc98e
@achingbrain @hugomrdias
chore: update .aegir.js
f92aaf2 
Co-Authored-By: Hugo Dias <hugomrdias@gmail.com>
fix: downgrade ky
f8ffc3d
@hugomrdias
Copy link
Member

can you rebase the commit onto master please ?

@alanshaw
Copy link
Member Author

#452

@alanshaw alanshaw closed this Jan 31, 2020
@alanshaw alanshaw deleted the fix/downgrade-ky branch January 31, 2020 11:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@achingbrain achingbrain achingbrain approved these changes

@hugomrdias hugomrdias Awaiting requested review from hugomrdias

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@alanshaw @hugomrdias @achingbrain