This repository was archived by the owner on Feb 12, 2024. It is now read-only.
Figure out why tests are failing #1072
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
assigned
daviddias
commented
Nov 12, 2017
| expect(last.path).to.be.eql('test-folder') | ||
| expect(last.hash).to.be.eql('QmY8TxNWtNViN7syd2DHazPqu21qWfSNjzCDe78e4YMsUD') | ||
| expect(last.path).to.eql('test-folder') | ||
| expect(last.hash).to.eql('Qmb3JNLq2KcvDTSGT23qNQkMrr4Y4fYMktHh6DtC7YatLa') |
There was a problem hiding this comment.
@pgte had to change this hash because now createTestFiles creates a clean array of files, resulting in a different hash. This means that js-ipfs-unixfs-engine mutates the files that are passed to it, this should be considered a bug.
|
I keep seeing these errors coming out from anywhere: |
|
Just seeing now |
|
Found the issue. Circuit Relay was always on by default, causing IPFS to fail when it had no addresses to dial from, but it had relay on. It was trying to use relay without knowing how to use any other transport). This is a bug in the Circuit Relay code, @dryajov |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Solved some issues on the sharding tsts, but still seems something is weird with that codebase, see: