This repository was archived by the owner on Sep 28, 2021. It is now read-only.
fix: fix content-type by doing a fall-back using extensions #5
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
satazor
force-pushed
the
fix-content-type
branch
4 times, most recently
from
feea5e1 to
d8688c0
Compare
The JS IPFS gateway was only responding with the correct content-type for some mime-types, see https://github.com/sindresorhus/file-type#supported-file-types. This commit now fall-backs to detecting based on the extension as well. Note that SVGs aren't supported by the `file-type` module.
satazor
force-pushed
the
fix-content-type
branch
from
d8688c0 to
e51b7ef
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
service-worker-gatewaywas only responding with the correct content-type for some mime-types, see https://github.com/sindresorhus/file-type#supported-file-types.This commit now fall-backs to detecting based on the extension as well.
Note that SVGs aren't supported by the
file-typemodule.