-
Notifications
You must be signed in to change notification settings - Fork 429
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Data-not-files: IPFS 101, FAQ, & Hashing changes #1022
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I've left a few comments, the rest looks great!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is a great PR! Everything is very clear and easy to understand! Nice work! Just requested a few minor changes.
|
||
## Content identifiers are not file hashes | ||
## Example: Content Identifiers are not file hashes |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
## Example: Content Identifiers are not file hashes | |
## Content identifiers are not file hashes |
IPFS follows particular data-structure preferences and conventions. The IPFS protocol uses those conventions and IPLD to get from raw content to an IPFS address that uniquely identifies content on the IPFS network. The next section explores how links between content are embedded within that content address through a DAG data structure. | ||
IPFS follows particular data-structure preferences and conventions. The IPFS protocol uses those conventions and IPLD to get from raw content to an IPFS address that uniquely identifies content on the IPFS network. | ||
|
||
The next section explores how links between content are embedded within that content address through a DAG data structure. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
content address
Is this meant to be content's address
or content identifier
?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Content identifier is more accurate in this context. Just committed to the nodes branch.
Co-authored-by: Johnny <9611008+johnnymatthews@users.noreply.github.com>
Co-authored-by: Johnny <9611008+johnnymatthews@users.noreply.github.com>
|
I'm getting confused with so many PRs working on the same files. @Annamarie2019 can we close this PR or are you planning on getting it merged along with other PRs? |
Sorry, that should have gone to the data-not-files branch. I'll close this one. |
Changes 3 files to address this issue (Answers issue #996):
After examining the overall Info Architecture of the IPFS doc, I think this repetition is fine: High level for newbies, occasional FAQs to reduce user frustration and save our time, and a detailed explanation for our nerdy friends.