Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

drag&drop to upload #26

Closed
daviddias opened this issue Aug 6, 2015 · 8 comments
Closed

drag&drop to upload #26

daviddias opened this issue Aug 6, 2015 · 8 comments
Milestone

Comments

@daviddias
Copy link
Member

Following: electron/electron#2433

ref: https://github.com/atom/electron/blob/master/docs/api/tray.md#event-drop-files

@jbenet
Copy link
Member

jbenet commented Aug 6, 2015

sweet! 👍

@daviddias
Copy link
Member Author

@whyrusleeping
Copy link
Member

can we not use https://github.com/feross/drag-drop for this?

@daviddias
Copy link
Member Author

@whyrusleeping not quite. We want to be able to drop to the tray icon, which isn't an html element.

It's working though, electron has some nice features that enable it (check drag-drop branch). Just missing a nice UI with bars and stuff spinning while it uploads (+ unicorns) and also a 'multi files' upload at the same time.

@daviddias
Copy link
Member Author

[x] Copy to the clipboard
[x] Show on the menubar

Need to make this look good

image

@jbenet
Copy link
Member

jbenet commented Aug 11, 2015

I'll design something tomorrow.

On Sun, Aug 9, 2015 at 9:38 AM, David Dias notifications@github.com wrote:

[x] Copy to the clipboard
[x] Show on the menubar

Need to make this look good

[image: image]
https://cloud.githubusercontent.com/assets/1211152/9153952/47c8b9f0-3e7a-11e5-83b1-749c3fbcc423.png


Reply to this email directly or view it on GitHub
#26 (comment).

@daviddias
Copy link
Member Author

Thank you @jbenet :)

All the code is in this branch, the current design looks like this:
image
The blue charging bar is while it uploads a file

@daviddias daviddias added this to the CCC milestone Aug 11, 2015
@daviddias
Copy link
Member Author

Added multiple file upload on the branch settings PR -> #32 Let's follow all of this there

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants