Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: go bin path #195

Merged
merged 1 commit into from
Mar 10, 2025
Merged

fix: go bin path #195

merged 1 commit into from
Mar 10, 2025
+2 −2

Conversation

2color
Copy link
Member

@2color 2color commented Mar 7, 2025

Title

Fix the way the go bin path is constructed if GOPATH is set. Make sure we also add bin to the path, because binaries live in the $GOPATH/bin.

See https://go.dev/wiki/GOPATH

@2color 2color requested a review from a team as a code owner March 7, 2025 15:37
SgtPooki
SgtPooki approved these changes Mar 7, 2025
View reviewed changes
Copy link
Member

@SgtPooki SgtPooki left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm.. conformance tests still run for me (no GOPATH set)

@2color 2color merged commit 3df98fc into main Mar 10, 2025
21 checks passed
@2color 2color deleted the fix-gopath-conformance branch March 10, 2025 15:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SgtPooki SgtPooki SgtPooki approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@2color @SgtPooki