test: gateway conformance failures are easier to debug #170
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Much nicer! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Title
test: gateway conformance failures are easier to debug
Description
Makes it easier to debug gateway-conformance failures when a code change causes a test that was previously passing to fail.
Notes & open questions
While working on #169, I ended up having to debug diffs of passing/failing gateway-conformance test outputs to figure out which exact check was failing. This PR makes it easier to debug such failures by printing the test output to the console when a test fails, and allowing us to specify which exact tests we expect to pass.
FYI, i got the names of the passing and failing tests by running:
Change checklist