fix(fsnode): issue #17 #18
Conversation
overbool
force-pushed
the
fix/issue-#17
branch
from
ffb1fae to
0899631
Compare
|
@schomatis, could u help me review it? |
unixfs.go
Outdated
| @@ -182,6 +182,21 @@ func NewFSNode(dataType pb.Data_DataType) *FSNode { | |||
| return n | |||
| } | |||
|
|
|||
| // Filesize gets filesize of format | |||
| func (n *FSNode) Filesize() uint64 { | |||
There was a problem hiding this comment.
This function already exists below, it can be deleted.
There was a problem hiding this comment.
@schomatis I had fixed it. Thx for your reply.
There was a problem hiding this comment.
@schomatis I am not sure whether we should delete FromBytes() in this pr.
There was a problem hiding this comment.
@schomatis I am not sure whether we should delete
FromBytes()in this pr.
No, it's still used in many other repos, but we should probably add a "deprecated" sign or a note recommending the use of FSNodeFromBytes.
overbool
force-pushed
the
fix/issue-#17
branch
from
0899631 to
978b7aa
Compare
overbool
force-pushed
the
fix/issue-#17
branch
from
978b7aa to
8118a03
Compare
unixfs.go
Outdated
| @@ -28,16 +28,6 @@ var ( | |||
| ErrUnrecognizedType = errors.New("unrecognized node type") | |||
| ) | |||
|
|
|||
| // FromBytes unmarshals a byte slice as protobuf Data. | |||
| func FromBytes(data []byte) (*pb.Data, error) { | |||
There was a problem hiding this comment.
So, let's restore this function as mentioned above and add a deprecation notice:
// Deprecated: Use `FSNodeFromBytes` instead to avoid direct manipulation of `pb.Data.format`.
There was a problem hiding this comment.
OK, I had added the Deprecated description.
overbool
force-pushed
the
fix/issue-#17
branch
from
8118a03 to
8bea61e
Compare
fix(fsnode): issue ipfs#17 This commit was moved from ipfs/go-unixfs@f68092e
Fixes: ipfs/kubo#5217, #17