This repository was archived by the owner on Jun 19, 2023. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 30
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
d450e54
to
e58c3d1
Compare
11498f4
to
80e1a84
Compare
Closed
e58c3d1
to
e1e1b7b
Compare
50d9cbf
to
428d919
Compare
gammazero
suggested changes
Apr 8, 2021
go.mod
Outdated
@@ -2,7 +2,9 @@ module github.com/ipfs/go-ipfs-blockstore | |||
|
|||
require ( | |||
github.com/davecgh/go-spew v1.1.1 // indirect | |||
github.com/gammazero/kmutex v1.0.0 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This needs to be updated to v1.0.1
. The v1.0.0
tag was pulling in the old version that this was forked from, which is not what you want.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The maintainer of the original repo accepted my changes, so now you can just use:
github.com/im7mortal/kmutex v1.0.1
gammazero
approved these changes
Apr 9, 2021
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Please rerun the benchmarks with the latest changes.
2 tasks
7dd260f
to
b44bb1f
Compare
b44bb1f
to
e8243a2
Compare
Closing based on #64 (comment). |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.