Skip to content
This repository was archived by the owner on Jun 19, 2023. It is now read-only.

fix(arc): Per-CID locking. KeyMutex #69

Closed
wants to merge 1 commit into from

Conversation

frrist
Copy link
Member

@frrist frrist commented Apr 7, 2021

No description provided.

@frrist frrist force-pushed the frrist/arc-cache-keymutex branch from d450e54 to e58c3d1 Compare April 7, 2021 17:07
@frrist frrist force-pushed the frrist/arc-cache-bench branch 2 times, most recently from 11498f4 to 80e1a84 Compare April 7, 2021 18:22
@frrist frrist mentioned this pull request Apr 7, 2021
@frrist frrist force-pushed the frrist/arc-cache-keymutex branch from e58c3d1 to e1e1b7b Compare April 7, 2021 18:52
@frrist frrist requested review from aschmahmann and gammazero April 7, 2021 19:19
@frrist frrist force-pushed the frrist/arc-cache-keymutex branch 2 times, most recently from 50d9cbf to 428d919 Compare April 8, 2021 18:44
go.mod Outdated
@@ -2,7 +2,9 @@ module github.com/ipfs/go-ipfs-blockstore

require (
github.com/davecgh/go-spew v1.1.1 // indirect
github.com/gammazero/kmutex v1.0.0

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This needs to be updated to v1.0.1. The v1.0.0 tag was pulling in the old version that this was forked from, which is not what you want.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The maintainer of the original repo accepted my changes, so now you can just use:

github.com/im7mortal/kmutex v1.0.1

@frrist frrist self-assigned this Apr 8, 2021
@frrist frrist requested a review from Stebalien April 8, 2021 19:13
Copy link

@gammazero gammazero left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Please rerun the benchmarks with the latest changes.

@frrist frrist mentioned this pull request Apr 26, 2021
2 tasks
@frrist frrist force-pushed the frrist/arc-cache-keymutex branch from 7dd260f to b44bb1f Compare May 3, 2021 19:06
@frrist frrist changed the base branch from frrist/arc-cache-bench to master May 3, 2021 19:08
@frrist frrist force-pushed the frrist/arc-cache-keymutex branch from b44bb1f to e8243a2 Compare May 3, 2021 19:18
@Stebalien
Copy link
Member

Closing based on #64 (comment).

@Stebalien Stebalien closed this May 4, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants