chore: short-circuit unnecessary message processing #290
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rvagg
commented
Dec 2, 2021
rvagg
force-pushed
the
rvagg/message-shunting
branch
from
1865483 to
8a576e1
Compare
marten-seemann
pushed a commit
that referenced
this pull request
Mar 2, 2023
* feat(impl): add spans to block events * fix(deps): update to go-ipfs-blockstore v1.1.2 * refactor(impl): clean up span naming
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@hannahhoward I noticed this when looking at some new traces I'm starting from
ReceiveMessage. The majority that come in through here don't have any requests, so going intoresponseManager.ProcessRequestsgets it put into the message handling loop and eventually hit aforloop that iterates over an empty slice and does nothing else. On the other side,requestManager.ProcessResponseshas the same thing but even more branches where it hits variousforloops to collect and process things over an empty slice when there's no responses or blocks.So, minor optimisation, but seems to be worthwhile given how chatty this call seems to be.