This repository was archived by the owner on Jun 20, 2024. It is now read-only.
refactor(docker): simplify Dockerfile, fix arm64 #159
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
this aims to remove tini an su-exec complexity and use arch-specific binaries from alpine instead
willscott
approved these changes
Jun 30, 2023
galargh
approved these changes
Jun 30, 2023
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR aims to remove some overengineering around
tiniandsu-exec(most likely copied form ipfs-cluster/kubo)and use arch-specific prebuilt binaries from alpine + have static binary that is less prone to errors due to annual glibc breakfest.
I've tested this commit in
stagingand producedipfs/bifrost-gateway:staging-2023-06-29-34a5f70runs fine on my Rpi4 (ARM64).The size does not differ much, imo independence of glibc and ARM64 fix are worth it.