Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(new-admin): add sgtpooki #17

Merged
merged 1 commit into from
Mar 17, 2023
Merged

Conversation

SgtPooki
Copy link
Contributor

need permissions to create helia example repos

Summary

Adding SgtPooki to admin for ipfs-examples so new examples can be added easily.

Why do you need this?

Needed in order to create helia example repos according to instructions at https://github.com/ipfs-examples/helia-examples#how-to-add-a-new-example

What else do we need to know?

It could be better if we directed people to this repo if simply adding an additional repo in this file would create it and allow the pulling from the root to work properly.

thoughts @achingbrain @galargh ?

DRI: @SgtPooki

Reviewer's Checklist

  • It is clear where the request is coming from (if unsure, ask)
  • All the automated checks passed
  • The YAML changes reflect the summary of the request
  • The Terraform plan posted as a comment reflects the summary of the request

need permissions to create repos
@SgtPooki SgtPooki requested review from a team as code owners March 17, 2023 18:21
@github-actions
Copy link
Contributor

Before merge, verify that all the following plans are correct. They will be applied as-is after the merge.

Terraform plans

ipfs-examples

Terraform used the selected providers to generate the following execution
plan. Resource actions are indicated with the following symbols:
  + create

Terraform will perform the following actions:

  # github_membership.this["sgtpooki"] will be created
  + resource "github_membership" "this" {
      + etag     = (known after apply)
      + id       = (known after apply)
      + role     = "admin"
      + username = "sgtpooki"
    }

Plan: 1 to add, 0 to change, 0 to destroy.

@2color 2color merged commit a03c6cb into ipfs-examples:master Mar 17, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants