Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

no internet connection #197

Closed
xtimbeau opened this issue Sep 8, 2021 · 6 comments
Closed

no internet connection #197

xtimbeau opened this issue Sep 8, 2021 · 6 comments
Assignees
Labels

Comments

@xtimbeau
Copy link

xtimbeau commented Sep 8, 2021

Apparently when no internet connection available and even is the jar for R5 is cached, setup_r5 fails. Looks like issue #163.
XT

@xtimbeau
Copy link
Author

xtimbeau commented Sep 8, 2021

to be more specific, it is when the connection attempt is timing out. Apparently there is no error returned in that case and r5r assumes the connection is live, but fails to download metadata

@rafapereirabr
Copy link
Member

Hi @xtimbeau. Thanks for opening this issue. According to CRAN policies, the function should "fail gracefully" by simply returning a message when there is no internet connection. This should be done with the check_connection() support function in r5r, but apparently this is not working as expected.I'll look into this, but it might take a couple weeks for me to solve this issue due to other commitments.

If you know already how to address this problem, please go ahead and submit a pull request.

@xtimbeau
Copy link
Author

xtimbeau commented Sep 10, 2021 via email

@dhersz
Copy link
Member

dhersz commented Oct 21, 2021

As per 9c0ed76 r5r doesn't require internet to fetch the metadata anymore. Instead, it always uses the metadata stored inside extdata.

Also, b9193cf ensures that check_connection() is used properly, "failing gracefully" when either the user doesn't have internet access or the IPEA's server is not responding.

These commits, when coupled, reduces r5r's internet dependency quite considerably. Internet is now only required to download the latest R5 jar if it hasn't been downloaded before.

@dhersz dhersz closed this as completed Oct 21, 2021
@rafapereirabr
Copy link
Member

Thanks, Daniel. Could you please document this in the NEWS file?

@dhersz
Copy link
Member

dhersz commented Oct 22, 2021

Done.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants