-
Notifications
You must be signed in to change notification settings - Fork 31
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
no internet connection #197
Comments
to be more specific, it is when the connection attempt is timing out. Apparently there is no error returned in that case and r5r assumes the connection is live, but fails to download metadata |
Hi @xtimbeau. Thanks for opening this issue. According to CRAN policies, the function should "fail gracefully" by simply returning a message when there is no internet connection. This should be done with the If you know already how to address this problem, please go ahead and submit a pull request. |
hi, the problem occurs when the download_metadata() is timing out. The
reason why is unclear to me, but it is not an issue with internet. I was
using r5r on an azure machine in europe and support suggested to me it was
linked to connection with brazil. Whatever, a turnaround would be to add an
option to skip the donwload_metadata part and behave like there was no
internet connection. Thus it would use the donwloaded jar directly.
All the best
XT
Le ven. 10 sept. 2021 à 22:18, Rafael H M Pereira ***@***.***>
a écrit :
… Hi @xtimbeau <https://github.com/xtimbeau>. Thanks for opening this
issue. According to CRAN policies, the function should "fail gracefully" by
simply returning a message when there is no internet connection. This
should be done with the check_connection() support function in r5r, but
apparently this is not working as expected.I'll look into this, but it
might take a couple weeks for me to solve this issue due to other
commitments.
If you know already how to address this problem, please go ahead and
submit a pull request.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#197 (comment)>, or
unsubscribe
<https://github.com/notifications/unsubscribe-auth/ANA2KEM75IY2U7YFXNHP52DUBJRZZANCNFSM5DUSDDMQ>
.
|
As per 9c0ed76 r5r doesn't require internet to fetch the metadata anymore. Instead, it always uses the metadata stored inside Also, b9193cf ensures that These commits, when coupled, reduces r5r's internet dependency quite considerably. Internet is now only required to download the latest R5 jar if it hasn't been downloaded before. |
Thanks, Daniel. Could you please document this in the |
Done. |
Apparently when no internet connection available and even is the jar for R5 is cached, setup_r5 fails. Looks like issue #163.
XT
The text was updated successfully, but these errors were encountered: