Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(consensus): Gargabe Collection - 2 #5668

Open
wants to merge 1 commit into
base: consensus/feat/garbage-collector-1
Choose a base branch
from

Conversation

piotrm50
Copy link
Contributor

Description of change

Porting upstream change: MystenLabs/sui@6d9b1f9

This is the second part of Garbage Collection which implements the
following ticked next steps as outlined on the previous PR

  • BlockManager to respect the gc_round when accepting blocks and
    trigger clean ups for new gc rounds
  • Skip blocks that are received which are <= gc_round
  • Not propose ancestors that are <= gc_round
  • Subscriber to ask for blocks from gc_round when
    last_fetched_round < gc_round for a peer to prevent us from fetching
    unnecessary blocks

Next steps:

  • Re-propose GC'ed transactions (probably not all of them)
  • Implement new timestamp approach so ancestor verification is not
    needed
  • Harden testing for GC & edge cases

Links to any relevant issues

Be sure to reference any related issues by adding fixes #(issue).

Type of change

Choose a type of change, and delete any options that are not relevant.

  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

How the change has been tested

Describe the tests that you ran to verify your changes.

Make sure to provide instructions for the maintainer as well as any relevant configurations.

Change checklist

Tick the boxes that are relevant to your changes, and delete any items that are not.

  • I have followed the contribution guidelines for this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have added tests that prove my fix is effective or that my feature works
  • I have checked that new and existing unit tests pass locally with my changes

Copy link

vercel bot commented Feb 27, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

4 Skipped Deployments
Name Status Preview Comments Updated (UTC)
apps-backend ⬜️ Ignored (Inspect) Visit Preview Feb 27, 2025 4:34pm
apps-ui-kit ⬜️ Ignored (Inspect) Visit Preview Feb 27, 2025 4:34pm
rebased-explorer ⬜️ Ignored (Inspect) Visit Preview Feb 27, 2025 4:34pm
wallet-dashboard ⬜️ Ignored (Inspect) Visit Preview Feb 27, 2025 4:34pm

@iota-ci iota-ci added consensus Issues related to the Core Consensus team core-protocol labels Feb 27, 2025
@piotrm50 piotrm50 force-pushed the consensus/feat/garbage-collector-2 branch from 19a94ae to f03bb35 Compare February 27, 2025 15:34
@piotrm50 piotrm50 force-pushed the consensus/feat/garbage-collector-2 branch from f03bb35 to 55a5b7b Compare February 27, 2025 16:33
@piotrm50 piotrm50 marked this pull request as ready for review February 27, 2025 16:35
@piotrm50 piotrm50 requested a review from a team as a code owner February 27, 2025 16:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
consensus Issues related to the Core Consensus team core-protocol
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants