-
Notifications
You must be signed in to change notification settings - Fork 18
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(explorer): add staking ratio calculation #5614
base: develop
Are you sure you want to change the base?
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎
3 Skipped Deployments
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LG and works well 👍 just a nit about the hardcoded --
values
@@ -105,12 +109,19 @@ function ValidatorPageResult(): JSX.Element { | |||
const lastEpochRewardOnAllValidators = | |||
epochData?.data[0].endOfEpochInfo?.totalStakeRewardsDistributed; | |||
|
|||
const sortedValidators = activeValidatorsData?.sort(() => 0.5 - Math.random()); | |||
const stakingRatio = useMemo(() => { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
No need to use useMemo
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 👍
Description of change
Please write a summary of your changes and why you made them.
Links to any relevant issues
Closes #5607
Type of change
Choose a type of change, and delete any options that are not relevant.
How the change has been tested
Describe the tests that you ran to verify your changes.
Make sure to provide instructions for the maintainer as well as any relevant configurations.
Change checklist
Tick the boxes that are relevant to your changes, and delete any items that are not.