Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(consensus): Support one node committee #5612

Draft
wants to merge 7 commits into
base: consensus/feat/garbage-collector
Choose a base branch
from

Conversation

piotrm50
Copy link
Contributor

Description of change

Porting upstream change: MystenLabs/sui@6e6c72d

Obviously there is no fault tolerance. But this should be useful for running local cluster cheaply. min_round_delay should be set to a higher value for local cluster so not too many consensus blocks are built.

Merging to protocol-version-6 because this PR depends on RoundProber changes.

Type of change

Choose a type of change, and delete any options that are not relevant.

  • Enhancement (a non-breaking change which adds functionality)

How the change has been tested

Describe the tests that you ran to verify your changes.

Make sure to provide instructions for the maintainer as well as any relevant configurations.

Change checklist

Tick the boxes that are relevant to your changes, and delete any items that are not.

  • I have followed the contribution guidelines for this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have added tests that prove my fix is effective or that my feature works
  • I have checked that new and existing unit tests pass locally with my changes

@piotrm50 piotrm50 added the consensus Issues related to the Core Consensus team label Feb 25, 2025
@piotrm50 piotrm50 self-assigned this Feb 25, 2025
Copy link

vercel bot commented Feb 25, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

4 Skipped Deployments
Name Status Preview Comments Updated (UTC)
apps-backend ⬜️ Ignored (Inspect) Visit Preview Feb 26, 2025 6:48pm
apps-ui-kit ⬜️ Ignored (Inspect) Visit Preview Feb 26, 2025 6:48pm
rebased-explorer ⬜️ Ignored (Inspect) Visit Preview Feb 26, 2025 6:48pm
wallet-dashboard ⬜️ Ignored (Inspect) Visit Preview Feb 26, 2025 6:48pm

@piotrm50 piotrm50 force-pushed the core-protocol/protocol-version-6 branch from 36ef1c0 to f41d203 Compare February 26, 2025 05:11
@piotrm50 piotrm50 force-pushed the consensus/feat/support-one-node-committee branch from a712987 to 86101e2 Compare February 26, 2025 17:05
@piotrm50 piotrm50 marked this pull request as ready for review February 26, 2025 17:20
@piotrm50 piotrm50 requested review from a team as code owners February 26, 2025 17:20
@piotrm50 piotrm50 force-pushed the consensus/feat/support-one-node-committee branch from 99c60d5 to 111c00e Compare February 26, 2025 18:15
@piotrm50 piotrm50 changed the base branch from core-protocol/protocol-version-6 to consensus/feat/garbage-collector February 26, 2025 18:17
@piotrm50 piotrm50 requested review from a team as code owners February 26, 2025 18:17
@piotrm50 piotrm50 marked this pull request as draft February 26, 2025 18:21
@piotrm50 piotrm50 requested a review from muXxer February 26, 2025 18:21
@piotrm50 piotrm50 force-pushed the consensus/feat/garbage-collector branch from 2da3917 to e0be0ad Compare February 26, 2025 18:25
@piotrm50 piotrm50 force-pushed the consensus/feat/support-one-node-committee branch from 111c00e to 0b2e230 Compare February 26, 2025 18:26
@piotrm50 piotrm50 force-pushed the consensus/feat/support-one-node-committee branch from e704938 to 8f44440 Compare February 26, 2025 18:46
@piotrm50 piotrm50 force-pushed the consensus/feat/garbage-collector branch from e0be0ad to f41d203 Compare February 27, 2025 15:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
consensus Issues related to the Core Consensus team core-protocol
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants