Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Wait for checkpoint service to stop during reconfig #5412

Conversation

bingyanglin
Copy link
Contributor

@bingyanglin bingyanglin commented Feb 17, 2025

Description of change

This is the pre-required PR for issue #4692
Apply the bug fixing from [Checkpoint] wait for checkpoint service to stop during reconfig #17556:

Currently during reconfig, CheckpointService tasks, including CheckpointBuilder and CheckpointAggregator, are notified to shut down. But reconfig does not wait for them to finish shutting down. There can be a race between the reconfig loop proceeding to drop the epoch db handle, while CheckpointBuilder tries to read from epoch db when creating a new checkpoint. The race can result in panics.

Links to any relevant issues

fixes #5411

Type of change

  • Bug fix (a non-breaking change which fixes an issue)

How the change has been tested

Ran the local network with RUST_LOG=info cargo run --release --bin iota start --force-regenesis --with-faucet

Change checklist

Tick the boxes that are relevant to your changes, and delete any items that are not.

  • I have followed the contribution guidelines for this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have added tests that prove my fix is effective or that my feature works
  • I have checked that new and existing unit tests pass locally with my changes

@bingyanglin bingyanglin self-assigned this Feb 17, 2025
Copy link

vercel bot commented Feb 17, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

4 Skipped Deployments
Name Status Preview Comments Updated (UTC)
apps-backend ⬜️ Ignored (Inspect) Feb 17, 2025 7:16am
apps-ui-kit ⬜️ Ignored (Inspect) Feb 17, 2025 7:16am
rebased-explorer ⬜️ Ignored (Inspect) Feb 17, 2025 7:16am
wallet-dashboard ⬜️ Ignored (Inspect) Feb 17, 2025 7:16am

@bingyanglin bingyanglin added the node Issues related to the Core Node team label Feb 17, 2025
@bingyanglin bingyanglin marked this pull request as ready for review February 17, 2025 07:34
@bingyanglin bingyanglin requested review from a team as code owners February 17, 2025 07:34
@bingyanglin
Copy link
Contributor Author

bingyanglin commented Feb 17, 2025

Duplicate of #5391

@bingyanglin bingyanglin marked this as a duplicate of #5391 Feb 17, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
core-protocol node Issues related to the Core Node team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Checkpoint] wait for checkpoint service to stop during reconfig #17556
2 participants