feat(node): expose underlying byte slice #5400
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 4 Skipped Deployments
|
bingyanglin
changed the title
Base automatically changed from
sc-platform/issue-4551-pull-external-crates-changes
to
develop
February 14, 2025 15:05
bingyanglin
force-pushed
the
core-node/expose-underlying-byte-slice
branch
from
82fe3ae to
48ba356
Compare
github-actions
bot
added
documentation
bingyanglin
force-pushed
the
core-node/expose-underlying-byte-slice
branch
from
48ba356 to
acb928b
Compare
bingyanglin
removed
documentation
bingyanglin
commented
Feb 16, 2025
| } | ||
| } | ||
|
|
||
| impl Field<'_, '_> { |
There was a problem hiding this comment.
Note that here we use Field<'_, '_> instead of using impl<'b, 'l> Field<'b, 'l> in the upstream change to fix the Lint error.
jkrvivian
approved these changes
Feb 17, 2025
muXxer
approved these changes
Feb 17, 2025
piotrm50
approved these changes
Feb 18, 2025
This was referenced Feb 18, 2025
Closed
This was referenced Feb 20, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of change
This PR enhanced the
dynamic_fieldand itsvisitor, as well as refactored the relatediota-corecodes, based on move(visitor): expose underlying byte slice #19517 and the changes on #4559. Note that the changes incrates/iota-types/src/object/balance_traversal.rswas already included in thedevelopbranch.@iotaledger/infrastructure would you please also check if
iota-analytics-indexer,iota-graphql-rpc, andiota-indexerneed related changes as in move(visitor): expose underlying byte slice #19517, thanks!Links to any relevant issues based on the latest change of Move, also
fixes #4783 #4774 #4775 #4773 #4681 #4680
Type of change
How the change has been tested
Ran the local network with
RUST_LOG=info cargo run --release --bin iota start --force-regenesis --with-faucetChange checklist
Tick the boxes that are relevant to your changes, and delete any items that are not.