Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor(iota-genesis-builder): Remove template files for native tokens package builder #5353

Merged
merged 11 commits into from
Feb 17, 2025
Merged

refactor(iota-genesis-builder): Remove template files for native tokens package builder #5353

merged 11 commits into from
Feb 17, 2025

Conversation

miker83z
Copy link
Contributor

@miker83z miker83z commented Feb 12, 2025 •
edited
Loading

Description of change

  • Removed the package_template package files
  • Added 2 constants for representing the 2 needed files: the template module, the template Move.toml
  • Make the package template use a git revision for fetching the iota-framework/stardust dependency

Links to any relevant issues

Closes #5352

Type of change

  • Enhancement (a non-breaking change which adds functionality)

How the change has been tested

  • cargo run --release --bin iota-genesis-builder -- --disable-global-snapshot-verification iota --snapshot-path ../test-latest-full_snapshot.bin --target-network alphanet-test

Change checklist

  • I have followed the contribution guidelines for this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have added tests that prove my fix is effective or that my feature works
  • I have checked that new and existing unit tests pass locally with my changes

@miker83z miker83z requested a review from samuel-rufi February 12, 2025 09:10
@miker83z miker83z self-assigned this Feb 12, 2025
@vercel Vercel
Copy link

vercel bot commented Feb 12, 2025 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

4 Skipped Deployments
Name Status Preview Comments Updated (UTC)
apps-backend ⬜️ Ignored (Inspect) Visit Preview Feb 17, 2025 11:27am
apps-ui-kit ⬜️ Ignored (Inspect) Visit Preview Feb 17, 2025 11:27am
rebased-explorer ⬜️ Ignored (Inspect) Visit Preview Feb 17, 2025 11:27am
wallet-dashboard ⬜️ Ignored (Inspect) Visit Preview Feb 17, 2025 11:27am

@miker83z miker83z added the vm-language Issues related to the VM & Language Team label Feb 12, 2025
@iota-ci iota-ci added the sc-platform Issues related to the Smart Contract Platform group. label Feb 12, 2025
@miker83z miker83z marked this pull request as ready for review February 14, 2025 11:31
@miker83z miker83z requested a review from a team as a code owner February 14, 2025 11:31
nonast
nonast approved these changes Feb 17, 2025
View reviewed changes
Copy link
Contributor

@nonast nonast left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

samuel-rufi
samuel-rufi approved these changes Feb 17, 2025
View reviewed changes
Copy link
Member

@samuel-rufi samuel-rufi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice! Better instead of copying over the files

@miker83z miker83z requested review from a team as code owners February 17, 2025 10:59
@miker83z miker83z force-pushed the vm-lang/native-token-package-builder-refactor branch from 3485cd3 to c393d63 Compare February 17, 2025 11:05
@miker83z miker83z merged commit 7798c77 into develop Feb 17, 2025
41 checks passed
@miker83z miker83z deleted the vm-lang/native-token-package-builder-refactor branch February 17, 2025 14:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@valeriyr valeriyr valeriyr approved these changes

@piotrm50 piotrm50 piotrm50 approved these changes

@samuel-rufi samuel-rufi samuel-rufi approved these changes

@Dkwcs Dkwcs Dkwcs approved these changes

@nonast nonast nonast approved these changes

@muXxer muXxer muXxer approved these changes

Assignees

@miker83z miker83z

Labels
sc-platform Issues related to the Smart Contract Platform group. vm-language Issues related to the VM & Language Team
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[genesis] Refactor the native tokens package builder to avoid reading template files using the file system
8 participants
@miker83z @valeriyr @piotrm50 @samuel-rufi @Dkwcs @nonast @muXxer @iota-ci