fix(types): avoid deserialization when fetching ID of non-upgraded packages #5261
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 4 Skipped Deployments
|
bingyanglin
approved these changes
Feb 7, 2025
miker83z
approved these changes
Feb 7, 2025
jkrvivian
force-pushed
the
node/fix/avoid-deserialize-id-of-unupgraded-pkg
branch
from
aee3826 to
95f7518
Compare
DaughterOfMars
approved these changes
Feb 7, 2025
lucas-tortora
pushed a commit
that referenced
this pull request
Feb 11, 2025
…ckages (#5261) Signed-off-by: Lucas Tortora <lucass.tortora@iota.org>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of change
Merge an enhancement from upstream: MystenLabs/sui@11ddc9e
The
original_package_idfunction is showing up in some slow traces, so make it less expensive in the (common) case of grabbing the ID of a non-upgraded packageLinks to any relevant issues
Close #4688
Type of change
Change checklist