Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore(iota): Set active address when generating first new address #5173

Merged
merged 7 commits into from
Feb 7, 2025
Merged

chore(iota): Set active address when generating first new address #5173

merged 7 commits into from
Feb 7, 2025

Conversation

DaughterOfMars
Copy link
Contributor

Description

Sets the config active_address when generating a new address.

Also sets the active_env when a new config is created or when setting envs, if it was not already set.

@DaughterOfMars DaughterOfMars requested a review from a team as a code owner February 3, 2025 18:24
@vercel Vercel
Copy link

vercel bot commented Feb 3, 2025 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
apps-backend ✅ Ready (Inspect) Visit Preview 💬 Add feedback Feb 6, 2025 1:48pm
rebased-explorer ✅ Ready (Inspect) Visit Preview 💬 Add feedback Feb 6, 2025 1:48pm
wallet-dashboard ✅ Ready (Inspect) Visit Preview 💬 Add feedback Feb 6, 2025 1:48pm
1 Skipped Deployment
Name Status Preview Comments Updated (UTC)
apps-ui-kit ⬜️ Ignored (Inspect) Visit Preview 💬 Add feedback Feb 6, 2025 1:48pm

@iota-ci iota-ci added dev-tools Issues related to the Developer Tools Team sc-platform Issues related to the Smart Contract Platform group. labels Feb 3, 2025
thibault-martinez
thibault-martinez requested changes Feb 6, 2025
View reviewed changes
Copy link
Member

@thibault-martinez thibault-martinez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've just tried this and it did not set the active address

@DaughterOfMars
Copy link
Contributor Author

I've just tried this and it did not set the active address

Yeah, I forgot that one of the benefits of implementing the trait was that we could call generate_and_add_new_key and it would set the active address...

@thibault-martinez thibault-martinez merged commit 03bde29 into develop Feb 7, 2025
41 checks passed
@thibault-martinez thibault-martinez deleted the dev-tools/new-address-active branch February 7, 2025 20:04
@DaughterOfMars DaughterOfMars mentioned this pull request Feb 11, 2025
Open
lucas-tortora pushed a commit that referenced this pull request Feb 11, 2025
@DaughterOfMars @thibault-martinez
chore(iota): Set active address when generating first new address (#5173
6ccaf05 
)

* chore(iota): Set active address when generating first new address

* Also set active env

* Remove keystore impl

* remove signature

* just set it :c

---------

Co-authored-by: Thibault Martinez <thibault@iota.org>
Signed-off-by: Lucas Tortora <lucass.tortora@iota.org>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Alex6323 Alex6323 Alex6323 left review comments

@Thoralf-M Thoralf-M Thoralf-M approved these changes

@thibault-martinez thibault-martinez thibault-martinez approved these changes

Assignees
No one assigned
Labels
dev-tools Issues related to the Developer Tools Team sc-platform Issues related to the Smart Contract Platform group.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@DaughterOfMars @thibault-martinez @Alex6323 @Thoralf-M @iota-ci