feat(cli)!: make committee size configurable in iota start
#5162
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 4 Skipped Deployments
|
iota-ci
added
dev-tools
|
@iotaledger/dev-tools Any preference whether we want to use the term |
Thoralf-M
approved these changes
Feb 3, 2025
samuel-rufi
approved these changes
Feb 5, 2025
miker83z
approved these changes
Feb 6, 2025
thibault-martinez
approved these changes
Feb 6, 2025
thibault-martinez
changed the title
iota startiota start
lucas-tortora
pushed a commit
that referenced
this pull request
Feb 11, 2025
* make committee size configurable * rename num_validators to committee_size * add warning * Update crates/iota/src/iota_commands.rs * rm match Co-authored-by: DaughterOfMars <chloedaughterofmars@gmail.com> * fmt * nits * remove more newlines --------- Co-authored-by: Thibault Martinez <thibault@iota.org> Co-authored-by: DaughterOfMars <chloedaughterofmars@gmail.com> Signed-off-by: Lucas Tortora <lucass.tortora@iota.org>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of change
This PR adds the
--committee-sizeflag to theiota startcommand to allow for configurable number of validators. The upsteam change MystenLabs/sui#20511 also added this for theiota genesiscommand, but that feature we already added some time ago with the--num-validatorsoption. This PR therefore renames the argument on theiota genesiscommand to make both commands consistent.Links to any relevant issues
fixes #4914
Type of change
How the change has been tested
Tested it locally by:
(a) running
iota start --committee-size 3on an empty config directory -> correctly resulted in 3 validator configs being generated(b) running
iota start --committee-size 10on a non-empty config director -> correctly resulted in this flag being ignored, and the same initial committee size of 3Change checklist
Tick the boxes that are relevant to your changes, and delete any items that are not.