Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(indexer): Simplify WrappedOrDeleted variant #5119

Merged
merged 1 commit into from
Feb 4, 2025

Conversation

tomxey
Copy link
Contributor

@tomxey tomxey commented Jan 31, 2025

Description of change

Cleanup unnecessary fields from ObjectKind::WrappedOrDeleted

Links to any relevant issues

fixes #5114

Type of change

Refactor

How the change has been tested

cargo nextest run -p iota-graphql-rpc --features pg_integration --no-fail-fast --test-threads 1

Change checklist

Tick the boxes that are relevant to your changes, and delete any items that are not.

  • I have followed the contribution guidelines for this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have added tests that prove my fix is effective or that my feature works
  • I have checked that new and existing unit tests pass locally with my changes

@tomxey tomxey self-assigned this Jan 31, 2025
Copy link

vercel bot commented Jan 31, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

4 Skipped Deployments
Name Status Preview Comments Updated (UTC)
apps-backend ⬜️ Ignored (Inspect) Visit Preview Jan 31, 2025 0:56am
apps-ui-kit ⬜️ Ignored (Inspect) Visit Preview 💬 Add feedback Jan 31, 2025 0:56am
rebased-explorer ⬜️ Ignored (Inspect) Visit Preview Jan 31, 2025 0:56am
wallet-dashboard ⬜️ Ignored (Inspect) Visit Preview 💬 Add feedback Jan 31, 2025 0:56am

@iota-ci iota-ci added infrastructure Issues related to the Infrastructure Team sc-platform Issues related to the Smart Contract Platform group. labels Jan 31, 2025
@tomxey tomxey marked this pull request as ready for review January 31, 2025 13:57
@tomxey tomxey requested a review from a team as a code owner January 31, 2025 13:57
Copy link
Contributor

@sergiupopescu199 sergiupopescu199 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm 🚀

@tomxey tomxey merged commit 478cf94 into develop Feb 4, 2025
68 checks passed
@tomxey tomxey deleted the sc-platform/wrapped-or-deleted-cleanup branch February 4, 2025 08:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
infrastructure Issues related to the Infrastructure Team sc-platform Issues related to the Smart Contract Platform group.
Projects
None yet
4 participants