feat(admin): Return error status code from admin console if tracing is disabled on startup. #5092
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 4 Skipped Deployments
|
daria305
force-pushed
the
core-node/feat/admin-console-tracing
branch
from
cacc678 to
32870f9
Compare
muXxer
requested changes
Jan 30, 2025
muXxer
approved these changes
Jan 30, 2025
semenov-vladyslav
approved these changes
Jan 30, 2025
nmrshll
approved these changes
Jan 30, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of change
Because tracing might be expensive operation, tracing is not enabled by default and it can be enabled only if node operator provide TRACE_FILTER on the node startup.
The admin interface endpoints:
enable-tracingandreset_tracingallow to start and reset level of tracing but they work only if tracing was enabled on the node startup. Currently admin endpoint always returned OK status and information about ignoring request was only printed in logs, what was misleading. Now we correctly inform that tracing cannot be enabled and why.Links to any relevant issues
Related to #4322
Type of change
Choose a type of change, and delete any options that are not relevant.
How the change has been tested
Tested by running a node and using admin api
Change checklist
Tick the boxes that are relevant to your changes, and delete any items that are not.