fix(genesis-builder): Always destroy allocation objects when picked #5028
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 4 Skipped Deployments
|
iota-ci
added
sc-platform
muXxer
approved these changes
Jan 27, 2025
6 tasks
Base automatically changed from
vm-language/examine-genesis-checkpoint
to
develop
January 28, 2025 11:41
valeriyr
approved these changes
Jan 28, 2025
Comment on lines
168
to
174
| Data::Move(_) => GasCoin::try_from(&object) | ||
| .map(|gas| gas.value()) | ||
| .or_else(|_| TimeLock::<Balance>::try_from(&object).map(|t| t.locked().value())) | ||
| .or_else(|_| AliasOutput::try_from(&object).map(|a| a.balance.value())) | ||
| .or_else(|_| BasicOutput::try_from(&object).map(|b| b.balance.value())) | ||
| .or_else(|_| NftOutput::try_from(&object).map(|n| n.balance.value())) | ||
| .unwrap_or(0), |
There was a problem hiding this comment.
Any chance we can avoid this by checking a type byte or something?
There was a problem hiding this comment.
That object is encoded through a Move Struct, so unfortunately I don't see an easy change to support a type byte.
lzpap
approved these changes
Jan 28, 2025
There was a problem hiding this comment.
Yaay, it worked! 🎉
Total Number of Validators: 4
Total Number of Migration Objects: 4561398
Total Number of Objects/Packages: 4561441
Total Supply of Iota: 4600000000000000000 NANOS or 4600000000 IOTA
Total Amount of StakedIota: 45000000000000000 NANOS or 45000000 IOTA
lzpap
pushed a commit
that referenced
this pull request
Jan 29, 2025
…5028) * fix: examine genesis checkpoint * chore: clippy and fmt * refactor: is_maybe to try_from * chore: remove unused functions * refactor: remove unwrap from func * chore: remove unused to_bytes funcs * chore: cargo fmt * chore: correct spelling * fix(genesis-inspector): consider TimelockedStakedIota as a stake * feat(genesis-builder): validate migration objects after build * fix(genesis-builder): always destroy allocation objects when picked * revert changes to pick_objects_for_allocation * fix(iota-genesis-builder): destroy timelocks after split PTB * fix(migration_tx_data): add timelock gas balance check --------- Co-authored-by: nonast <29281463+nonast@users.noreply.github.com>
Merged
6 tasks
lzpap
pushed a commit
that referenced
this pull request
Jan 29, 2025
…5028) * fix: examine genesis checkpoint * chore: clippy and fmt * refactor: is_maybe to try_from * chore: remove unused functions * refactor: remove unwrap from func * chore: remove unused to_bytes funcs * chore: cargo fmt * chore: correct spelling * fix(genesis-inspector): consider TimelockedStakedIota as a stake * feat(genesis-builder): validate migration objects after build * fix(genesis-builder): always destroy allocation objects when picked * revert changes to pick_objects_for_allocation * fix(iota-genesis-builder): destroy timelocks after split PTB * fix(migration_tx_data): add timelock gas balance check --------- Co-authored-by: nonast <29281463+nonast@users.noreply.github.com>
lzpap
added a commit
that referenced
this pull request
Jan 29, 2025
…5028) (#5081) * fix: examine genesis checkpoint * chore: clippy and fmt * refactor: is_maybe to try_from * chore: remove unused functions * refactor: remove unwrap from func * chore: remove unused to_bytes funcs * chore: cargo fmt * chore: correct spelling * fix(genesis-inspector): consider TimelockedStakedIota as a stake * feat(genesis-builder): validate migration objects after build * fix(genesis-builder): always destroy allocation objects when picked * revert changes to pick_objects_for_allocation * fix(iota-genesis-builder): destroy timelocks after split PTB * fix(migration_tx_data): add timelock gas balance check --------- Co-authored-by: Mirko Zichichi <miker83z@proton.me> Co-authored-by: nonast <29281463+nonast@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of change
Fixes #5024 (it also adds a validation of the migrated objects after the genesis build)
Type of change
How the change has been tested
cargo run --release --bin iota genesis-ceremony build-unsigned-checkpoint --local-migration-snapshots stardust_object_snapshot.binChange checklist