chore(cli): Improve error message for attempting genesis with non-empty config dir #4987
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 4 Skipped Deployments
|
iota-ci
added
dev-tools
Thoralf-M
approved these changes
Jan 30, 2025
Co-authored-by: DaughterOfMars <chloedaughterofmars@gmail.com>
DaughterOfMars
approved these changes
Feb 3, 2025
thibault-martinez
approved these changes
Feb 10, 2025
lucas-tortora
pushed a commit
that referenced
this pull request
Feb 11, 2025
…ty config dir (#4987) * port error message for genesis on non-empty config dir * format * move newlines to end Co-authored-by: DaughterOfMars <chloedaughterofmars@gmail.com> * remove artifact * do not ignore genesis upstream error --------- Co-authored-by: DaughterOfMars <chloedaughterofmars@gmail.com> Co-authored-by: Thibault Martinez <thibault@iota.org> Signed-off-by: Lucas Tortora <lucass.tortora@iota.org>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of change
Ports the error message of MystenLabs/sui#19487
Deviates from the upstream PR and does fix some very small issues not worth a dedicated PR that are closely related to the intent of this PR. Upstream ignores errors produced by the
genesisfn, and assumes a single reason for it to fail in that particular code path. Some reasons for it to fail are still possible though, so the actual error would be hidden from the user, which is not ideal.How the change was tested
Ran
iota startwith a non-empty config directory by renamingnetwork.yamlto something else, which triggers that code path.Links to any relevant issues
fixes #4926