[iota-indexer] Remove mysql-feature gated code from indexer, ungate postgres-feature code #4954

tomxey · 2025-01-21T14:19:00Z

Description of change

Remove all code gated by mysql-feature feature flag.
Always enable all code gated by postgres-feature feature flag, and remove the flag.

Links to any relevant issues

solves part of #4904

Type of change

Refactoring

How the change has been tested

cargo ci-clippy
cargo nextest run -p iota-graphql-rpc --features pg_integration --no-fail-fast --test-threads 1
cargo test --package=iota-indexer --profile simulator --features shared_test_runtime
cargo test --package=iota-indexer --features pg_integration -- --test-threads 1

Change checklist

Tick the boxes that are relevant to your changes, and delete any items that are not.

I have followed the contribution guidelines for this project
I have performed a self-review of my own code
I have commented my code, particularly in hard-to-understand areas
I have made corresponding changes to the documentation
I have added tests that prove my fix is effective or that my feature works
I have checked that new and existing unit tests pass locally with my changes

vercel · 2025-01-21T14:19:07Z

The latest updates on your projects. Learn more about Vercel for Git ↗︎

4 Skipped Deployments

Name	Status	Preview	Updated (UTC)
apps-backend	⬜️ Ignored (Inspect)	Visit Preview	Jan 23, 2025 9:24am
apps-ui-kit	⬜️ Ignored (Inspect)	Visit Preview	Jan 23, 2025 9:24am
rebased-explorer	⬜️ Ignored (Inspect)	Visit Preview	Jan 23, 2025 9:24am
wallet-dashboard	⬜️ Ignored (Inspect)	Visit Preview	Jan 23, 2025 9:24am

… code

kodemartin

looks good with minor suggestions

kodemartin · 2025-01-22T09:00:52Z

crates/iota-indexer/README.md

@@ -171,5 +171,5 @@ Note that you need an existing database for this to work. Using the DATABASE_URL

 ```sh
 # Change the RPC_CLIENT_URL to http://0.0.0.0:9000 to run indexer against local validator & fullnode
-cargo run --bin iota-indexer --features mysql-feature --no-default-features -- --db-url "<DATABASE_URL>" --rpc-client-url "https://api.devnet.iota.cafe:443" --fullnode-sync-worker --reset-db
+cargo run --bin iota-indexer -- --db-url "<DATABASE_URL>" --rpc-client-url "https://api.devnet.iota.cafe:443" --fullnode-sync-worker --reset-db


The whole Run with TiDB... section is now obsolete and can be removed.

Done in a6eb68e

kodemartin · 2025-01-22T09:39:50Z

crates/iota-graphql-rpc/src/types/event/mod.rs

-                stored.senders.first()
-            }
-        }) else {
+        let Some(Some(sender_bytes)) = ({ stored.senders.first() }) else {


Nit: Simplification

Suggested change

let Some(Some(sender_bytes)) = ({ stored.senders.first() }) else {

let Some(Some(sender_bytes)) = stored.senders.first() else {

Done in f501d28

crates/iota-graphql-rpc/Cargo.toml

crates/iota-indexer/Cargo.toml

DaughterOfMars

I can't help but feel like maybe this is too much. Do we really not want to support this kind of extensibility in the future? We could just remove the feature and leave the generics to allow for the possibility.

kodemartin · 2025-01-22T16:09:29Z

I can't help but feel like maybe this is too much. Do we really not want to support this kind of extensibility in the future? We could just remove the feature and leave the generics to allow for the possibility.

I am afraid I see little merit in keeping the generics just in case we will need it in the future. It adds complexity to the API, and makes it hard to reason about its use, or maintain it while working on or extending dependent components, when we only see a single database being supported.

DaughterOfMars · 2025-01-22T16:33:32Z

I can't help but feel like maybe this is too much. Do we really not want to support this kind of extensibility in the future? We could just remove the feature and leave the generics to allow for the possibility.

I am afraid I see little merit in keeping the generics just in case we will need it in the future. It adds complexity to the API, and makes it hard to reason about its use, or maintain it while working on or extending dependent components, when we only see a single database being supported.

Am I wrong in thinking that users of the lib could add their own implementations? If that's the case, we are removing that option.

kodemartin · 2025-01-23T07:55:22Z

I can't help but feel like maybe this is too much. Do we really not want to support this kind of extensibility in the future? We could just remove the feature and leave the generics to allow for the possibility.

I am afraid I see little merit in keeping the generics just in case we will need it in the future. It adds complexity to the API, and makes it hard to reason about its use, or maintain it while working on or extending dependent components, when we only see a single database being supported.

Am I wrong in thinking that users of the lib could add their own implementations? If that's the case, we are removing that option.

You are not wrong, but the fact remains: This is just a possibility, and I am of the opinion that adding complexity to the API is best dictated by actual feature requests, or feedback. This is not the case here.

Also, this library is not the same as the ingestion framework (iota-data-ingestion-core) that is more oriented toward builders.

At any case, we can certainly revisit if the need arises.

…ostgres-feature code (#4954) * Remove mysql-feature gated code from indexer, ungate postgres-feature code * Remove empty default features from Cargo.tomls * Simplify code * Remove TiDB readme section

tomxey self-assigned this Jan 21, 2025

tomxey added sc-platform Issues related to the Smart Contract Platform group. infrastructure Issues related to the Infrastructure Team labels Jan 21, 2025

tomxey mentioned this pull request Jan 21, 2025

[indexer, graphql] Drop TiDB/MySQL support #4904

Closed

Remove mysql-feature gated code from indexer, ungate postgres-feature…

723daa6

… code

tomxey force-pushed the sc-platform/remove-mysql-feature-flag-gated-code-from-indexer branch from eed1312 to 723daa6 Compare January 21, 2025 14:48

tomxey marked this pull request as ready for review January 22, 2025 07:34

tomxey requested review from a team as code owners January 22, 2025 07:34

tomxey requested review from samuel-rufi, kodemartin and sergiupopescu199 January 22, 2025 08:21

kodemartin approved these changes Jan 22, 2025

View reviewed changes

sergiupopescu199 approved these changes Jan 22, 2025

View reviewed changes

DaughterOfMars reviewed Jan 22, 2025

View reviewed changes

crates/iota-graphql-rpc/Cargo.toml Outdated Show resolved Hide resolved

DaughterOfMars reviewed Jan 22, 2025

View reviewed changes

crates/iota-indexer/Cargo.toml Outdated Show resolved Hide resolved

DaughterOfMars reviewed Jan 22, 2025

View reviewed changes

tomxey added 3 commits January 23, 2025 10:22

Remove empty default features from Cargo.tomls

ede8035

Simplify code

f501d28

Remove TiDB readme section

a6eb68e

tomxey requested a review from DaughterOfMars January 23, 2025 09:31

DaughterOfMars approved these changes Jan 23, 2025

View reviewed changes

tomxey merged commit 78ab453 into develop Jan 23, 2025
39 checks passed

tomxey deleted the sc-platform/remove-mysql-feature-flag-gated-code-from-indexer branch January 23, 2025 13:45

tomxey mentioned this pull request Jan 23, 2025

[indexer]: Finalize mysql/tidb cleanup #4997

Merged

6 tasks

lzpap mentioned this pull request Jan 30, 2025

[cherry-pick] indexer features for 0.9.2-beta release #5096

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[iota-indexer] Remove mysql-feature gated code from indexer, ungate postgres-feature code #4954

[iota-indexer] Remove mysql-feature gated code from indexer, ungate postgres-feature code #4954

tomxey commented Jan 21, 2025 •

edited

Loading

vercel bot commented Jan 21, 2025 •

edited

Loading

kodemartin left a comment

kodemartin Jan 22, 2025

tomxey Jan 23, 2025

kodemartin Jan 22, 2025

tomxey Jan 23, 2025

DaughterOfMars left a comment

kodemartin commented Jan 22, 2025

DaughterOfMars commented Jan 22, 2025

kodemartin commented Jan 23, 2025 •

edited

Loading

	let Some(Some(sender_bytes)) = ({ stored.senders.first() }) else {
	let Some(Some(sender_bytes)) = stored.senders.first() else {

[iota-indexer] Remove mysql-feature gated code from indexer, ungate postgres-feature code #4954

[iota-indexer] Remove mysql-feature gated code from indexer, ungate postgres-feature code #4954

Conversation

tomxey commented Jan 21, 2025 • edited Loading

Description of change

Links to any relevant issues

Type of change

How the change has been tested

Change checklist

vercel bot commented Jan 21, 2025 • edited Loading

kodemartin left a comment

Choose a reason for hiding this comment

kodemartin Jan 22, 2025

Choose a reason for hiding this comment

tomxey Jan 23, 2025

Choose a reason for hiding this comment

kodemartin Jan 22, 2025

Choose a reason for hiding this comment

tomxey Jan 23, 2025

Choose a reason for hiding this comment

DaughterOfMars left a comment

Choose a reason for hiding this comment

kodemartin commented Jan 22, 2025

DaughterOfMars commented Jan 22, 2025

kodemartin commented Jan 23, 2025 • edited Loading

tomxey commented Jan 21, 2025 •

edited

Loading

vercel bot commented Jan 21, 2025 •

edited

Loading

kodemartin commented Jan 23, 2025 •

edited

Loading