fix(core): Fix crashes in execution_driver due to inability to execute transactions

[jkrvivian]

Description of change

Merge bug fix from upstream: MystenLabs/sui@675ea8c

From upstream PR description:

Fix crashes in execution_driver due to inability to execute transactions.

We must hold the lock for the object entry while inserting to the
object_by_id_cache. Otherwise, a surprising bug can occur:

1. A thread executing TX1 can write object (O,1) to the dirty set and then pause.
2. TX2, which reads (O,1) can begin executing, because TransactionManager immediately schedules transactions if their inputs are available. It does not matter that TX1 hasn't finished executing yet.
3. TX2 can write (O,2) to both the dirty set and the object_by_id_cache.
4. The thread executing TX1 can resume and write (O,1) to the object_by_id_cache.

Now, any subsequent attempt to get the latest version of O will return (O,1) instead of
(O,2).

This seems very unlikely, but it may be more likely under the following circumstances:

• While a thread is unlikely to pause for so long, moka cache uses optimistic lock-free algorithms that have retry loops. Possibly, under high contention, this code might spin for a surprisingly long time.
• Additionally, many concurrent re-executions of the same tx could happen due to the tx finalizer, plus checkpoint executor, consensus, and RPCs from fullnodes.

Unfortunately I have not been able to reproduce this bug, so we cannot be sure that
this fixes the crashes we've seen. But this is certainly a possible bug.

Links to any relevant issues

Close #4675

Type of change

• Bug fix

Change checklist

• I have followed the contribution guidelines for this project
• I have performed a self-review of my own code
• I have commented my code, particularly in hard-to-understand areas
• I have checked that new and existing unit tests pass locally with my changes

[vercel]

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name	Status	Preview	Comments	Updated (UTC)
apps-backend	✅ Ready (Inspect)	Visit Preview	💬 Add feedback	Jan 21, 2025 7:41am
apps-ui-kit	✅ Ready (Inspect)	Visit Preview	💬 Add feedback	Jan 21, 2025 7:41am
rebased-explorer	✅ Ready (Inspect)	Visit Preview	💬 Add feedback	Jan 21, 2025 7:41am
wallet-dashboard	✅ Ready (Inspect)	Visit Preview	💬 Add feedback	Jan 21, 2025 7:41am