Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(node): Fix retry logic in GCS and improve logging #4897

Merged
merged 3 commits into from
Jan 23, 2025

Conversation

bingyanglin
Copy link
Contributor

@bingyanglin bingyanglin commented Jan 19, 2025

Description of change

Fix retry logic in GCS and improve logging, refer to [formal snapshots] Fix retry logic in GCS and improve logging (#19470)

Links to any relevant issues

fixes #4669

Type of change

  • Bug fix

How the change has been tested

Ran the local network with RUST_LOG=info cargo run --release --bin iota start --force-regenesis --with-faucet

Change checklist

Tick the boxes that are relevant to your changes, and delete any items that are not.

  • I have followed the contribution guidelines for this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have added tests that prove my fix is effective or that my feature works
  • I have checked that new and existing unit tests pass locally with my changes

@bingyanglin bingyanglin added the node Issues related to the Core Node team label Jan 19, 2025
@bingyanglin bingyanglin self-assigned this Jan 19, 2025
Copy link

vercel bot commented Jan 19, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
apps-backend ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jan 22, 2025 1:05pm
apps-ui-kit ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jan 22, 2025 1:05pm
rebased-explorer ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jan 22, 2025 1:05pm
wallet-dashboard ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jan 22, 2025 1:05pm

@bingyanglin bingyanglin marked this pull request as ready for review January 20, 2025 03:45
@bingyanglin bingyanglin requested a review from a team as a code owner January 20, 2025 03:45
Copy link
Contributor

@muXxer muXxer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You forgot one change in another file:
image

@bingyanglin
Copy link
Contributor Author

You forgot one change in another file:

Sorry missed that. Update the changed at b18bb11.

@bingyanglin bingyanglin merged commit 6179d35 into develop Jan 23, 2025
38 of 39 checks passed
@bingyanglin bingyanglin deleted the core-node/fix/retry-logic branch January 23, 2025 08:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
core-protocol node Issues related to the Core Node team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[formal snapshots] Fix retry logic in GCS and improve logging (#19470) · MystenLabs/sui@260b0df
4 participants