chore(iota-graphql-rpc,move-vm-profiler,iota-node): Allow unexpected_cfgs and rework some macros
#4831
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
3 Skipped Deployments
|
iota-ci
added
dev-tools
kodemartin
approved these changes
Jan 16, 2025
…ed` to avoid compilation warnings
DaughterOfMars
changed the title
unexpected_cfgsunexpected_cfgs and rework some macros
thibault-martinez
approved these changes
Jan 22, 2025
valeriyr
approved these changes
Jan 22, 2025
muXxer
approved these changes
Jan 22, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Rust 1.84 detects an unexpected feature used via the
run_query_async!macro iniota-indexer, which assumes the possibility of amysql-featurefeature. This feature does not exist iniota-graphql-rpcand thus the compiler throws a warning. This PR ignores that warning.Additionally, the
gas_profiler_feature_enabledmacro uses anif cfg!(feature = "gas-profiler")check which is passed to the dependent crate and causes another warning. I have fixed this by removing that check (as it in not necessary anyway). This does cause an additional issue when using this macro to break early as it produces unreachable code warnings, so I added an additional functionis_gas_profiler_feature_enabledto handle this case.