Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(wallet): empty info box on shorter mnemonic #4781

Merged

Conversation

evavirseda
Copy link
Contributor

Description of change

Please write a summary of your changes and why you made them.

Links to any relevant issues

fixes #3915

Type of change

Choose a type of change, and delete any options that are not relevant.

  • Bug fix (a non-breaking change which fixes an issue)
  • Enhancement (a non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation Fix

How the change has been tested

Describe the tests that you ran to verify your changes.

Make sure to provide instructions for the maintainer as well as any relevant configurations.

Change checklist

Tick the boxes that are relevant to your changes, and delete any items that are not.

  • I have followed the contribution guidelines for this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have added tests that prove my fix is effective or that my feature works
  • I have checked that new and existing unit tests pass locally with my changes

@evavirseda evavirseda requested a review from a team as a code owner January 14, 2025 16:44
Copy link

vercel bot commented Jan 14, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
apps-backend ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jan 20, 2025 2:25pm
rebased-explorer ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jan 20, 2025 2:25pm
wallet-dashboard ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jan 20, 2025 2:25pm
1 Skipped Deployment
Name Status Preview Comments Updated (UTC)
apps-ui-kit ⬜️ Ignored (Inspect) Visit Preview Jan 20, 2025 2:25pm

@evavirseda evavirseda self-assigned this Jan 14, 2025
@github-actions github-actions bot added the wallet Issues related to the IOTA Wallet label Jan 14, 2025
@iota-ci iota-ci added the tooling Issues related to the Tooling team label Jan 14, 2025
Copy link
Contributor

@marc2332 marc2332 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It seems like now it won't render an error if you have a wrong mnemonic

image

@evavirseda evavirseda requested a review from marc2332 January 15, 2025 10:25
@vercel vercel bot temporarily deployed to Preview – apps-backend January 16, 2025 11:28 Inactive
@vercel vercel bot temporarily deployed to Preview – wallet-dashboard January 16, 2025 11:28 Inactive
@vercel vercel bot temporarily deployed to Preview – rebased-explorer January 16, 2025 11:28 Inactive
@begonaalvarezd begonaalvarezd merged commit 1dd7ecc into develop Jan 20, 2025
32 checks passed
@begonaalvarezd begonaalvarezd deleted the tooling-wallet/fix-empty-infobox-on-shorter-mnemonic branch January 20, 2025 18:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
tooling Issues related to the Tooling team wallet Issues related to the IOTA Wallet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Empty info box on shorter mnemonic
5 participants