Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(ts-sdk:dapp-kit): Improve connect-modal style #4771

Merged
merged 8 commits into from
Jan 21, 2025
Merged

feat(ts-sdk:dapp-kit): Improve connect-modal style #4771

merged 8 commits into from
Jan 21, 2025

Conversation

marc2332
Copy link
Contributor

Closes #4698

@marc2332 marc2332 added the tooling Issues related to the Tooling team label Jan 14, 2025
@marc2332 marc2332 self-assigned this Jan 14, 2025
@vercel Vercel
Copy link

vercel bot commented Jan 14, 2025 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
rebased-explorer ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jan 17, 2025 10:57am
wallet-dashboard ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jan 17, 2025 10:57am
2 Skipped Deployments
Name Status Preview Comments Updated (UTC)
apps-backend ⬜️ Ignored (Inspect) Visit Preview Jan 17, 2025 10:57am
apps-ui-kit ⬜️ Ignored (Inspect) Visit Preview Jan 17, 2025 10:57am

@github-actions github-actions bot added the ts-sdk Issues related to the TS SDK label Jan 14, 2025
@marc2332 marc2332 marked this pull request as ready for review January 14, 2025 12:15
@marc2332 marc2332 requested a review from a team as a code owner January 14, 2025 12:15
@github-actions GitHub Actions
Copy link
Contributor

This pull request has been deployed to Vercel.

Latest commit: 72d5ec1

✅ Preview: https://apps-backend-iw52u8zqd-iota1.vercel.app

@github-actions GitHub Actions
Copy link
Contributor

This pull request has been deployed to Vercel.

Latest commit: 72d5ec1

✅ Preview: https://rebased-explorer-4fvjf9odf-iota1.vercel.app

@github-actions GitHub Actions
Copy link
Contributor

This pull request has been deployed to Vercel.

Latest commit: 72d5ec1

✅ Preview: https://wallet-dashboard-41ov2gsfz-iota1.vercel.app

@begonaalvarezd begonaalvarezd changed the title feat: Improve connect-modal style feat(ts-sdk): Improve connect-modal style Jan 16, 2025
begonaalvarezd
begonaalvarezd requested changes Jan 16, 2025
View reviewed changes
Copy link
Member

@begonaalvarezd begonaalvarezd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Add minor changeset pls

@begonaalvarezd begonaalvarezd changed the title feat(ts-sdk): Improve connect-modal style feat(ts-sdk:dapp-kit): Improve connect-modal style Jan 16, 2025
@Dr-Electron
Copy link
Contributor

Dr-Electron commented Jan 17, 2025 •
edited
Loading

Maybe one comment. Should the IOTA logo be white in dark mode?
Black IOTA logo in dark mode

@marc2332
Copy link
Contributor Author

Maybe one comment. Should the IOTA logo be white in dark mode? Black IOTA logo in dark mode

Done!
image

@begonaalvarezd begonaalvarezd merged commit f0c83a2 into develop Jan 21, 2025
32 checks passed
@begonaalvarezd begonaalvarezd deleted the feat/improve-connect-modal-style branch January 21, 2025 10:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@begonaalvarezd begonaalvarezd begonaalvarezd approved these changes

@Dr-Electron Dr-Electron Dr-Electron approved these changes

@evavirseda evavirseda evavirseda approved these changes

Assignees

@marc2332 marc2332

Labels
tooling Issues related to the Tooling team ts-sdk Issues related to the TS SDK
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Fix connect wallet popup UI
4 participants
@marc2332 @Dr-Electron @begonaalvarezd @evavirseda