Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(wallet,wallet-dashboard): show fiat balance #4747

Merged
merged 26 commits into from
Jan 22, 2025
Merged

feat(wallet,wallet-dashboard): show fiat balance #4747

merged 26 commits into from
Jan 22, 2025

Conversation

VmMad
Copy link
Member

@VmMad VmMad commented Jan 10, 2025 •
edited by cpl121
Loading

Description of change

Fixes #3680, fixes #3679 and fixes #4724

⚠️ Depends on #4764

Type of change

Choose a type of change, and delete any options that are not relevant.

  • Enhancement (a non-breaking change which adds functionality)

How the change has been tested

Describe the tests that you ran to verify your changes.

Make sure to provide instructions for the maintainer as well as any relevant configurations.

Change checklist

Tick the boxes that are relevant to your changes, and delete any items that are not.

  • I have followed the contribution guidelines for this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have added tests that prove my fix is effective or that my feature works
  • I have checked that new and existing unit tests pass locally with my changes

@VmMad VmMad requested a review from a team as a code owner January 10, 2025 12:30
@VmMad VmMad added tooling Issues related to the Tooling team wallet-dashboard Issues related to the Wallet Dashboard dApp labels Jan 10, 2025
@github-actions GitHub Actions
Copy link
Contributor

This pull request has been deployed to Vercel.

Latest commit: c4d3a64

✅ Preview: https://apps-backend-2aw5uxj6y-iota1.vercel.app

@github-actions GitHub Actions
Copy link
Contributor

This pull request has been deployed to Vercel.

Latest commit: c4d3a64

✅ Preview: https://rebased-explorer-n8xu45r8l-iota1.vercel.app

@github-actions GitHub Actions
Copy link
Contributor

This pull request has been deployed to Vercel.

Latest commit: c4d3a64

✅ Preview: https://wallet-dashboard-3tf4oe3nh-iota1.vercel.app

cpl121
cpl121 requested changes Jan 13, 2025
View reviewed changes
@VmMad VmMad requested a review from cpl121 January 13, 2025 09:29
@github-actions github-actions bot added the apps-backend Issues related to the Apps Backend label Jan 13, 2025
@github-actions GitHub Actions
Copy link
Contributor

This pull request has been deployed to Vercel.

Latest commit: 65b6f6c

✅ Preview: https://rebased-explorer-f3yxxodys-iota1.vercel.app

@github-actions GitHub Actions
Copy link
Contributor

This pull request has been deployed to Vercel.

Latest commit: 65b6f6c

✅ Preview: https://wallet-dashboard-d095puqi1-iota1.vercel.app

@github-actions GitHub Actions
Copy link
Contributor

This pull request has been deployed to Vercel.

Latest commit: 31d97cb

✅ Preview: https://rebased-explorer-82ya1wlzu-iota1.vercel.app

@github-actions GitHub Actions
Copy link
Contributor

This pull request has been deployed to Vercel.

Latest commit: 31d97cb

✅ Preview: https://wallet-dashboard-nd2q38edh-iota1.vercel.app

@github-actions GitHub Actions
Copy link
Contributor

This pull request has been deployed to Vercel.

Latest commit: 7e8290e

✅ Preview: https://apps-backend-noeb948ie-iota1.vercel.app

@github-actions GitHub Actions
Copy link
Contributor

This pull request has been deployed to Vercel.

Latest commit: 7e8290e

✅ Preview: https://rebased-explorer-k27820khn-iota1.vercel.app

@github-actions GitHub Actions
Copy link
Contributor

This pull request has been deployed to Vercel.

Latest commit: 7e8290e

✅ Preview: https://wallet-dashboard-gmw1oy2qz-iota1.vercel.app

cpl121
cpl121 requested changes Jan 13, 2025
View reviewed changes
@github-actions GitHub Actions
Copy link
Contributor

This pull request has been deployed to Vercel.

Latest commit: a2028d4

✅ Preview: https://apps-backend-4k1rf96wm-iota1.vercel.app

@github-actions GitHub Actions
Copy link
Contributor

This pull request has been deployed to Vercel.

Latest commit: a2028d4

✅ Preview: https://rebased-explorer-16gxk5ecp-iota1.vercel.app

@github-actions GitHub Actions
Copy link
Contributor

This pull request has been deployed to Vercel.

Latest commit: a2028d4

✅ Preview: https://wallet-dashboard-473lygs6r-iota1.vercel.app

@github-actions github-actions bot added wallet Issues related to the IOTA Wallet explorer Issues related to the Explorer labels Jan 13, 2025
@VmMad VmMad requested a review from begonaalvarezd January 20, 2025 11:58
evavirseda
evavirseda requested changes Jan 20, 2025
View reviewed changes
Copy link
Contributor

@evavirseda evavirseda left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

tiny details 🙏

@VmMad VmMad requested a review from evavirseda January 20, 2025 15:04
begonaalvarezd
begonaalvarezd requested changes Jan 21, 2025
View reviewed changes
Copy link
Member

@begonaalvarezd begonaalvarezd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Switching networks from one with fiat enabled to one without, and the other way around, crashes the app 🙈
image
image

@begonaalvarezd begonaalvarezd changed the title feat(wallet/wallet-dashboard): show fiat balance feat(wallet, wallet-dashboard): show fiat balance Jan 21, 2025
@begonaalvarezd begonaalvarezd changed the title feat(wallet, wallet-dashboard): show fiat balance feat(wallet,wallet-dashboard): show fiat balance Jan 21, 2025
@begonaalvarezd begonaalvarezd merged commit e152092 into develop Jan 22, 2025
32 checks passed
@begonaalvarezd begonaalvarezd deleted the tooling-dashboard/hook-fiat-price branch January 22, 2025 14:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@begonaalvarezd begonaalvarezd begonaalvarezd approved these changes

@marc2332 marc2332 marc2332 approved these changes

@evavirseda evavirseda evavirseda approved these changes

@cpl121 cpl121 cpl121 approved these changes

Assignees
No one assigned
Labels
apps-backend Issues related to the Apps Backend explorer Issues related to the Explorer tooling Issues related to the Tooling team wallet Issues related to the IOTA Wallet wallet-dashboard Issues related to the Wallet Dashboard dApp
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Rename coingecko fiat pricing api Hook fiat pricing to wallet dashboard Hook fiat pricing to wallet
5 participants
@VmMad @begonaalvarezd @marc2332 @evavirseda @cpl121