Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor: implement graceful shutdown for IndexerExecutor #4648

Merged
merged 11 commits into from
Jan 30, 2025
Merged

refactor: implement graceful shutdown for IndexerExecutor #4648

merged 11 commits into from
Jan 30, 2025

Conversation

sergiupopescu199
Copy link
Contributor

Description of change

Implement graceful shutdown for the IndexerExecutor and its internal components.

This change does inherit changes from #4383

Links to any relevant issues

fixes #4581

Type of change

  • Enhancement (a non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

How the change has been tested

  • existing tests work as expected

Change checklist

Tick the boxes that are relevant to your changes, and delete any items that are not.

  • I have followed the contribution guidelines for this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have added tests that prove my fix is effective or that my feature works
  • I have checked that new and existing unit tests pass locally with my changes

@iota-ci iota-ci added infrastructure Issues related to the Infrastructure Team sc-platform Issues related to the Smart Contract Platform group. labels Dec 31, 2024
@sergiupopescu199 sergiupopescu199 linked an issue Dec 31, 2024 that may be closed by this pull request
[iota-data-ingestion-core]: Handle graceful shutdown #4581
Closed
Base automatically changed from sc-platform/issue-4383 to develop January 15, 2025 14:05
@vercel Vercel
Copy link

vercel bot commented Jan 17, 2025 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
apps-backend ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jan 30, 2025 2:06pm
apps-ui-kit ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jan 30, 2025 2:06pm
rebased-explorer ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jan 30, 2025 2:06pm
wallet-dashboard ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jan 30, 2025 2:06pm

@sergiupopescu199
Merge branch 'develop' into sc-platform/issue-4581
41f9587 
# Conflicts:
#	crates/iota-data-ingestion-core/src/executor.rs
#	crates/iota-data-ingestion-core/src/tests.rs
#	crates/iota-data-ingestion/src/main.rs
#	crates/iota-indexer-builder/src/iota_datasource.rs
#	crates/iota-indexer/src/indexer.rs
@sergiupopescu199 sergiupopescu199 marked this pull request as ready for review January 20, 2025 09:20
@sergiupopescu199 sergiupopescu199 requested review from a team as code owners January 20, 2025 09:20
kodemartin
kodemartin approved these changes Jan 23, 2025
View reviewed changes
Copy link
Contributor

@kodemartin kodemartin left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @sergiupopescu199, the logic looks great! I think however that the patch would benefit from a few refactorings as suggested more specifically.

tomxey
tomxey approved these changes Jan 23, 2025
View reviewed changes
Copy link
Contributor

@tomxey tomxey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm 🌾

@sergiupopescu199 sergiupopescu199 merged commit 3e02a8a into develop Jan 30, 2025
41 checks passed
@sergiupopescu199 sergiupopescu199 deleted the sc-platform/issue-4581 branch January 30, 2025 14:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tomxey tomxey tomxey approved these changes

@samuel-rufi samuel-rufi samuel-rufi approved these changes

@kodemartin kodemartin kodemartin approved these changes

@Alex6323 Alex6323 Alex6323 approved these changes

@Dr-Electron Dr-Electron Dr-Electron approved these changes

Assignees
No one assigned
Labels
infrastructure Issues related to the Infrastructure Team sc-platform Issues related to the Smart Contract Platform group.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[iota-data-ingestion-core]: Handle graceful shutdown
7 participants
@sergiupopescu199 @tomxey @samuel-rufi @kodemartin @Alex6323 @Dr-Electron @iota-ci