Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(docs): add notes about indexer in rpc specs #4584

Merged
merged 4 commits into from
Jan 17, 2025
Merged

fix(docs): add notes about indexer in rpc specs #4584

merged 4 commits into from
Jan 17, 2025

Conversation

Dr-Electron
Copy link
Contributor

Description of change

Some RPC endpoints are only available on indexer. So I added a note and changed the text where needed.

Links to any relevant issues

Fixes #4565.

Type of change

  • Documentation Fix

How the change has been tested

Run locally

Change checklist

  • I have followed the contribution guidelines for this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have added tests that prove my fix is effective or that my feature works
  • I have checked that new and existing unit tests pass locally with my changes

@Dr-Electron Dr-Electron requested review from a team as code owners December 20, 2024 12:22
@iota-ci iota-ci added the devx Issues related to the DevX team label Dec 20, 2024
@Dr-Electron Dr-Electron requested a review from a team December 20, 2024 12:22
lucas-tortora
lucas-tortora approved these changes Dec 20, 2024
View reviewed changes
Copy link
Contributor

@lucas-tortora lucas-tortora left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Besides @DaughterOfMars 's comments, LGTM :)

Thoralf-M
Thoralf-M requested changes Jan 7, 2025
View reviewed changes
Copy link
Member

@Thoralf-M Thoralf-M left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fmt failing, did you run cargo +nightly fmt?

@Dr-Electron Dr-Electron requested a review from Thoralf-M January 9, 2025 10:55
@thibault-martinez
Copy link
Member

Let's fix the conflicts and merge this

@vercel Vercel
Copy link

vercel bot commented Jan 17, 2025 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
apps-backend ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jan 17, 2025 11:40am
apps-ui-kit ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jan 17, 2025 11:40am
rebased-explorer ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jan 17, 2025 11:40am
wallet-dashboard ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jan 17, 2025 11:40am

@Dr-Electron Dr-Electron merged commit 1ec4a00 into develop Jan 17, 2025
37 of 39 checks passed
@Dr-Electron Dr-Electron deleted the devx/add-indexer-to-rpc-specs branch January 17, 2025 12:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@DaughterOfMars DaughterOfMars DaughterOfMars left review comments

@kodemartin kodemartin kodemartin approved these changes

@Thoralf-M Thoralf-M Thoralf-M approved these changes

@lucas-tortora lucas-tortora lucas-tortora approved these changes

@vivekjain23 vivekjain23 vivekjain23 approved these changes

Assignees
No one assigned
Labels
devx Issues related to the DevX team
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Document indexer-only RPC calls
8 participants
@Dr-Electron @thibault-martinez @kodemartin @DaughterOfMars @Thoralf-M @lucas-tortora @vivekjain23 @iota-ci