Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(wallet-dashboard): add tx details state to the end of migration flow #4547

Merged
merged 12 commits into from
Dec 19, 2024
Merged

feat(wallet-dashboard): add tx details state to the end of migration flow #4547

merged 12 commits into from
Dec 19, 2024

Conversation

evavirseda
Copy link
Contributor

Description of change

Please write a summary of your changes and why you made them.

Links to any relevant issues

fixes #4508

Type of change

Choose a type of change, and delete any options that are not relevant.

  • Bug fix (a non-breaking change which fixes an issue)
  • Enhancement (a non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation Fix

How the change has been tested

Describe the tests that you ran to verify your changes.

Make sure to provide instructions for the maintainer as well as any relevant configurations.

Change checklist

Tick the boxes that are relevant to your changes, and delete any items that are not.

  • I have followed the contribution guidelines for this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have added tests that prove my fix is effective or that my feature works
  • I have checked that new and existing unit tests pass locally with my changes

@evavirseda evavirseda requested a review from a team as a code owner December 18, 2024 12:59
@evavirseda evavirseda self-assigned this Dec 18, 2024
@iota-ci iota-ci added the tooling Issues related to the Tooling team label Dec 18, 2024
@evavirseda evavirseda added the wallet-dashboard Issues related to the Wallet Dashboard dApp label Dec 18, 2024
@github-actions GitHub Actions
Copy link
Contributor

This pull request has been deployed to Vercel.

Latest commit: c34de10

✅ Preview: https://wallet-dashboard-a225fcfa1e2f852205a61a7cd1d5d93e92-n76llxm4h.vercel.app

@github-actions GitHub Actions
Copy link
Contributor

This pull request has been deployed to Vercel.

Latest commit: 178c4da

✅ Preview: https://wallet-dashboard-a225fcfa1e2f852205a61a7cd1d5d93e92-jk3krfwsk.vercel.app

@github-actions GitHub Actions
Copy link
Contributor

This pull request has been deployed to Vercel.

Latest commit: 3993027

✅ Preview: https://wallet-dashboard-a225fcfa1e2f852205a61a7cd1d5d93e92-ce4okdf5y.vercel.app

@github-actions GitHub Actions
Copy link
Contributor

This pull request has been deployed to Vercel.

Latest commit: a74342d

✅ Preview: https://wallet-dashboard-a225fcfa1e2f852205a61a7cd1d5d93e92-cijkpdw6i.vercel.app

@github-actions GitHub Actions
Copy link
Contributor

This pull request has been deployed to Vercel.

Latest commit: f504225

✅ Preview: https://wallet-dashboard-a225fcfa1e2f852205a61a7cd1d5d93e92-l8sse1tl2.vercel.app

@evavirseda evavirseda mentioned this pull request Dec 19, 2024
Closed
@github-actions GitHub Actions
Copy link
Contributor

This pull request has been deployed to Vercel.

Latest commit: 7ca893f

✅ Preview: https://wallet-dashboard-f0pwsd8tp-iota1.vercel.app

brancoder
brancoder requested changes Dec 19, 2024
View reviewed changes
Copy link
Contributor

@brancoder brancoder left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we could add padding on the bottom for larger devices because the last item is not showing in the scroll panel

image

@github-actions GitHub Actions
Copy link
Contributor

This pull request has been deployed to Vercel.

Latest commit: d5534dc

✅ Preview: https://wallet-dashboard-ah7nh7cmc-iota1.vercel.app

@evavirseda evavirseda requested a review from brancoder December 19, 2024 10:49
@github-actions GitHub Actions
Copy link
Contributor

This pull request has been deployed to Vercel.

Latest commit: a40bfd3

✅ Preview: https://wallet-dashboard-p86rfb7oi-iota1.vercel.app

@github-actions GitHub Actions
Copy link
Contributor

This pull request has been deployed to Vercel.

Latest commit: de42eea

✅ Preview: https://wallet-dashboard-qyrfy60mi-iota1.vercel.app

brancoder
brancoder approved these changes Dec 19, 2024
View reviewed changes
Copy link
Contributor

@brancoder brancoder left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🎊

@cpl121 cpl121 merged commit 855e5bc into develop Dec 19, 2024
35 checks passed
@cpl121 cpl121 deleted the tooling-dashboard/add-tx-details-to-migration-flow branch December 19, 2024 14:44
miker83z pushed a commit that referenced this pull request Dec 20, 2024
@evavirseda @miker83z
feat(wallet-dashboard): add tx details state to the end of migration …
d3ff797 
…flow (#4547)

* feat: add tx details for migration

* feat: add skeleton and remode debris

* feat: redirect to home after migrate

* fix height
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@panteleymonchuk panteleymonchuk panteleymonchuk approved these changes

@brancoder brancoder brancoder approved these changes

@cpl121 cpl121 cpl121 approved these changes

@marc2332 marc2332 Awaiting requested review from marc2332

Assignees

@evavirseda evavirseda

Labels
tooling Issues related to the Tooling team wallet-dashboard Issues related to the Wallet Dashboard dApp
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add tx details state to the end of migration flow
6 participants
@evavirseda @panteleymonchuk @marc2332 @brancoder @cpl121 @iota-ci