Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(docs): mint ctf completion nft #4521

Merged
merged 16 commits into from
Jan 16, 2025
Merged

feat(docs): mint ctf completion nft #4521

merged 16 commits into from
Jan 16, 2025

Conversation

vivekjain23
Copy link
Contributor

@vivekjain23 vivekjain23 commented Dec 17, 2024 •
edited
Loading

Description of change

This PR brings up the enhancement of NFT minting on completion of the CTF challenge.

Links to any relevant issues

Fixes #4133

Type of change

  • Enhancement (a non-breaking change which adds functionality)

How the change has been tested

Changes were built locally

Change checklist

  • I have followed the contribution guidelines for this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have added tests that prove my fix is effective or that my feature works
  • I have checked that new and existing unit tests pass locally with my changes

@github-actions github-actions bot added the documentation Improvements or additions to documentation label Dec 17, 2024
@iota-ci iota-ci added the devx Issues related to the DevX team label Dec 17, 2024
@vivekjain23 vivekjain23 added the dx-documentation For TW or documentation related issues. label Dec 17, 2024
@vivekjain23 vivekjain23 marked this pull request as ready for review December 17, 2024 15:08
@vivekjain23 vivekjain23 requested a review from a team as a code owner December 17, 2024 15:08
@github-actions GitHub Actions
Copy link
Contributor

✅ Vercel Preview Deployment is ready!

View Preview

@vivekjain23 vivekjain23 changed the title Devx/mint completion nft feat(docs): mint completion nft Dec 18, 2024
@github-actions GitHub Actions
Copy link
Contributor

✅ Vercel Preview Deployment is ready!

View Preview

@vivekjain23 vivekjain23 changed the title feat(docs): mint completion nft feat(docs): mint ctf completion nft Dec 19, 2024
@github-actions GitHub Actions
Copy link
Contributor

✅ Vercel Preview Deployment is ready!

View Preview

@github-actions GitHub Actions
Copy link
Contributor

✅ Vercel Preview Deployment is ready!

View Preview

@lucas-tortora
Copy link
Contributor

@vivekjain23 , I'm getting these errors when attempting to get the first NFT. My account has 10 IOTAs, so in theory, we should have enough for gas. If it helps I can record a short video

Screenshot from 2024-12-19 09-50-21
Screenshot from 2024-12-19 09-50-03

@github-actions GitHub Actions
Copy link
Contributor

✅ Vercel Preview Deployment is ready!

View Preview

lucas-tortora
lucas-tortora requested changes Jan 8, 2025
View reviewed changes
Copy link
Contributor

@lucas-tortora lucas-tortora left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One small comment about casing in the nftName Param

@vivekjain23 vivekjain23 requested a review from a team as a code owner January 9, 2025 07:44
@github-actions github-actions bot added the wallet-dashboard Issues related to the Wallet Dashboard dApp label Jan 9, 2025
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Jan 9, 2025

This pull request has been deployed to Vercel.

Latest commit: 658f068

✅ Preview: https://apps-backend-hz7nrbur6-iota1.vercel.app

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Jan 9, 2025

This pull request has been deployed to Vercel.

Latest commit: 658f068

✅ Preview: https://rebased-explorer-k1qbbq2jm-iota1.vercel.app

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Jan 9, 2025

This pull request has been deployed to Vercel.

Latest commit: 658f068

✅ Preview: https://wallet-dashboard-98evcypwy-iota1.vercel.app

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Jan 9, 2025

✅ Vercel Preview Deployment is ready!

View Preview

@github-actions GitHub Actions
Copy link
Contributor

This pull request has been deployed to Vercel.

Latest commit: 4badf6d

✅ Preview: https://apps-backend-1t3s12me9-iota1.vercel.app

@github-actions GitHub Actions
Copy link
Contributor

This pull request has been deployed to Vercel.

Latest commit: 4badf6d

✅ Preview: https://rebased-explorer-3uwpf79rh-iota1.vercel.app

@github-actions GitHub Actions
Copy link
Contributor

This pull request has been deployed to Vercel.

Latest commit: 4badf6d

✅ Preview: https://wallet-dashboard-8vbi4yie7-iota1.vercel.app

@github-actions GitHub Actions
Copy link
Contributor

✅ Vercel Preview Deployment is ready!

View Preview

@github-actions GitHub Actions
Copy link
Contributor

✅ Vercel Preview Deployment is ready!

View Preview

@github-actions GitHub Actions
Copy link
Contributor

✅ Vercel Preview Deployment is ready!

View Preview

@vivekjain23 vivekjain23 merged commit ffd581a into develop Jan 16, 2025
36 checks passed
@vivekjain23 vivekjain23 deleted the devx/mint-completion-nft branch January 16, 2025 05:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@begonaalvarezd begonaalvarezd begonaalvarezd approved these changes

@lucas-tortora lucas-tortora lucas-tortora approved these changes

Assignees
No one assigned
Labels
devx Issues related to the DevX team documentation Improvements or additions to documentation dx-documentation For TW or documentation related issues. wallet-dashboard Issues related to the Wallet Dashboard dApp
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Mint a completion NFT to the user upon finishing each challenge
4 participants
@vivekjain23 @lucas-tortora @begonaalvarezd @iota-ci