Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(CI): Refactor and re-enable simulator nightly #4430

Merged
merged 4 commits into from
Dec 17, 2024

Conversation

DaughterOfMars
Copy link
Contributor

Description of change

Removes the teleport functionality from the simulator nightly workflow and refactors it so that the tests are run on our self hosted runner.

Removes the reporting job as this is already handled elsewhere.

Links to any relevant issues

Closes #4290

@iota-ci iota-ci added dev-tools Issues related to the Developer Tools Team sc-platform Issues related to the Smart Contract Platform group. labels Dec 10, 2024
@DaughterOfMars
Copy link
Contributor Author

Run here: https://github.com/iotaledger/iota/actions/runs/12278874595/job/34261557947

Two tests are currently failing. I can address these issues here to wait for a subsequent PR.

@thibault-martinez
Copy link
Member

thibault-martinez commented Dec 11, 2024

Is the only difference with the PR simtest job that it runs them all?

@DaughterOfMars
Copy link
Contributor Author

Is the only difference with the PR simtest job that it runs them all?

simtest_run.sh does a lot of stuff with benchmarking and such that is not done by running the simtest command alone

@thibault-martinez
Copy link
Member

Run here: https://github.com/iotaledger/iota/actions/runs/12278874595/job/34261557947

Two tests are currently failing. I can address these issues here to wait for a subsequent PR.

Please open issues for the failing ones.

@DaughterOfMars
Copy link
Contributor Author

Issue for failing tests: #4477

@thibault-martinez thibault-martinez merged commit 2d61a55 into develop Dec 17, 2024
41 of 42 checks passed
@thibault-martinez thibault-martinez deleted the dev-tools/sim-nightly branch December 17, 2024 08:52
miker83z pushed a commit that referenced this pull request Dec 20, 2024
* chore(CI): Refactor and re-enable simulator nightly

* change default ref

* Combine nightly workflows

---------

Co-authored-by: Thibault Martinez <thibault@iota.org>
jkrvivian pushed a commit that referenced this pull request Jan 6, 2025
* chore(CI): Refactor and re-enable simulator nightly

* change default ref

* Combine nightly workflows

---------

Co-authored-by: Thibault Martinez <thibault@iota.org>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dev-tools Issues related to the Developer Tools Team sc-platform Issues related to the Smart Contract Platform group.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

CI: re-enable simulator_nightly.yml
4 participants