Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(tooling): fix logo/avatar/icon image, move to core and cleanup debris #4249

Merged
merged 11 commits into from
Dec 3, 2024

Conversation

evavirseda
Copy link
Contributor

Description of change

Please write a summary of your changes and why you made them.

Links to any relevant issues

fixes #3939

Type of change

Choose a type of change, and delete any options that are not relevant.

  • Bug fix (a non-breaking change which fixes an issue)
  • Enhancement (a non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation Fix

How the change has been tested

Describe the tests that you ran to verify your changes.

Make sure to provide instructions for the maintainer as well as any relevant configurations.

Change checklist

Tick the boxes that are relevant to your changes, and delete any items that are not.

  • I have followed the contribution guidelines for this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have added tests that prove my fix is effective or that my feature works
  • I have checked that new and existing unit tests pass locally with my changes

@evavirseda evavirseda added tooling Issues related to the Tooling team wallet Issues related to the IOTA Wallet explorer Issues related to the Explorer labels Nov 26, 2024
@evavirseda evavirseda self-assigned this Nov 26, 2024
@evavirseda evavirseda requested review from a team as code owners November 26, 2024 14:32
Copy link
Contributor

This pull request has been deployed to Vercel.

Latest commit: c981278

✅ Preview: https://iota-rebased-explorer-092603f1de8088243ccb8b861b23e-c4d8j1sbu.vercel.app

Copy link
Contributor

This pull request has been deployed to Vercel.

Latest commit: c981278

✅ Preview: https://wallet-dashboard-a225fcfa1e2f852205a61a7cd1d5d93e92-k84ub1vo5.vercel.app

Copy link
Contributor

This pull request has been deployed to Vercel.

Latest commit: c981278

✅ Preview: https://apps-backend-29a719c9ccbdb9b80c97b599a599d8953354da-lgst4afd3.vercel.app

Copy link
Contributor

This pull request has been deployed to Vercel.

Latest commit: 99f3619

✅ Preview: https://apps-backend-29a719c9ccbdb9b80c97b599a599d8953354da-gszc7hanm.vercel.app

Copy link
Contributor

This pull request has been deployed to Vercel.

Latest commit: 99f3619

✅ Preview: https://iota-rebased-explorer-092603f1de8088243ccb8b861b23e-hz95kk5sc.vercel.app

Copy link
Contributor

This pull request has been deployed to Vercel.

Latest commit: 99f3619

✅ Preview: https://wallet-dashboard-a225fcfa1e2f852205a61a7cd1d5d93e92-iwvdikn3x.vercel.app

Copy link
Contributor

This pull request has been deployed to Vercel.

Latest commit: b7b5596

✅ Preview: https://apps-backend-29a719c9ccbdb9b80c97b599a599d8953354da-l2v5o2q8k.vercel.app

Copy link
Contributor

This pull request has been deployed to Vercel.

Latest commit: b7b5596

✅ Preview: https://iota-rebased-explorer-092603f1de8088243ccb8b861b23e-kfqofj773.vercel.app

Copy link
Contributor

@brancoder brancoder left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good just lint issues 🙏

Copy link
Contributor

This pull request has been deployed to Vercel.

Latest commit: 2746156

✅ Preview: https://apps-backend-29a719c9ccbdb9b80c97b599a599d8953354da-3eomstec9.vercel.app

Copy link
Contributor

This pull request has been deployed to Vercel.

Latest commit: 2746156

✅ Preview: https://iota-rebased-explorer-092603f1de8088243ccb8b861b23e-5p4sbgyoa.vercel.app

Copy link
Contributor

This pull request has been deployed to Vercel.

Latest commit: 2746156

✅ Preview: https://wallet-dashboard-a225fcfa1e2f852205a61a7cd1d5d93e92-r0f8zz5av.vercel.app

Copy link
Member

@VmMad VmMad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

This pull request has been deployed to Vercel.

Latest commit: a045820

✅ Preview: https://apps-backend-29a719c9ccbdb9b80c97b599a599d8953354da-kp37hnfps.vercel.app

Copy link
Contributor

This pull request has been deployed to Vercel.

Latest commit: a045820

✅ Preview: https://iota-rebased-explorer-092603f1de8088243ccb8b861b23e-3zlidqgur.vercel.app

Copy link
Contributor

This pull request has been deployed to Vercel.

Latest commit: a045820

✅ Preview: https://wallet-dashboard-a225fcfa1e2f852205a61a7cd1d5d93e92-5ut5xfa8y.vercel.app

Copy link
Contributor

This pull request has been deployed to Vercel.

Latest commit: cfda774

✅ Preview: https://iota-rebased-explorer-092603f1de8088243ccb8b861b23e-b4abx8hff.vercel.app

Copy link
Contributor

This pull request has been deployed to Vercel.

Latest commit: cfda774

✅ Preview: https://apps-backend-29a719c9ccbdb9b80c97b599a599d8953354da-mg1z8fxjg.vercel.app

Copy link
Contributor

This pull request has been deployed to Vercel.

Latest commit: cfda774

✅ Preview: https://wallet-dashboard-a225fcfa1e2f852205a61a7cd1d5d93e92-mqezpf9r5.vercel.app

Copy link
Contributor

This pull request has been deployed to Vercel.

Latest commit: 784ef7e

✅ Preview: https://iota-rebased-explorer-092603f1de8088243ccb8b861b23e-d7zbp3iyw.vercel.app

Copy link
Contributor

This pull request has been deployed to Vercel.

Latest commit: 784ef7e

✅ Preview: https://apps-backend-29a719c9ccbdb9b80c97b599a599d8953354da-necvudb43.vercel.app

Copy link
Contributor

This pull request has been deployed to Vercel.

Latest commit: 784ef7e

✅ Preview: https://wallet-dashboard-a225fcfa1e2f852205a61a7cd1d5d93e92-9t6mj2bi2.vercel.app

Copy link
Contributor

github-actions bot commented Dec 3, 2024

This pull request has been deployed to Vercel.

Latest commit: 88c65e7

✅ Preview: https://apps-backend-29a719c9ccbdb9b80c97b599a599d8953354da-zg40l2bcf.vercel.app

Copy link
Contributor

github-actions bot commented Dec 3, 2024

This pull request has been deployed to Vercel.

Latest commit: 88c65e7

✅ Preview: https://iota-rebased-explorer-092603f1de8088243ccb8b861b23e-jcrfkguxn.vercel.app

Copy link
Contributor

github-actions bot commented Dec 3, 2024

This pull request has been deployed to Vercel.

Latest commit: 88c65e7

✅ Preview: https://wallet-dashboard-a225fcfa1e2f852205a61a7cd1d5d93e92-99l8xqa9w.vercel.app

Copy link
Contributor

@brancoder brancoder left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🎊

Copy link
Contributor

@brancoder brancoder left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: unused import

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This file has a leftover React import that is not added in this Pr but maybe we can remove it?

@evavirseda evavirseda requested a review from brancoder December 3, 2024 14:27
Copy link
Contributor

github-actions bot commented Dec 3, 2024

This pull request has been deployed to Vercel.

Latest commit: 3137a66

✅ Preview: https://iota-rebased-explorer-092603f1de8088243ccb8b861b23e-gyz4j313d.vercel.app

Copy link
Contributor

github-actions bot commented Dec 3, 2024

This pull request has been deployed to Vercel.

Latest commit: 3137a66

✅ Preview: https://apps-backend-29a719c9ccbdb9b80c97b599a599d8953354da-ek8h9k8le.vercel.app

Copy link
Contributor

github-actions bot commented Dec 3, 2024

This pull request has been deployed to Vercel.

Latest commit: 3137a66

✅ Preview: https://wallet-dashboard-a225fcfa1e2f852205a61a7cd1d5d93e92-9eccj1whu.vercel.app

Copy link
Contributor

@brancoder brancoder left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🎊

@brancoder brancoder merged commit d12200c into develop Dec 3, 2024
34 checks passed
@brancoder brancoder deleted the tooling/style-and-cleanup-image-icons branch December 3, 2024 14:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
explorer Issues related to the Explorer tooling Issues related to the Tooling team wallet Issues related to the IOTA Wallet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Fix logo/avatar/icon image, move to core and cleanup debris
4 participants