Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(wallet, dashboard): use validator image when possible #4247

Merged
merged 3 commits into from
Nov 27, 2024

Conversation

VmMad
Copy link
Member

@VmMad VmMad commented Nov 26, 2024

Description of change

Please write a summary of your changes and why you made them.

Links to any relevant issues

Fixes #4179

Type of change

  • Bug fix (a non-breaking change which fixes an issue)

How the change has been tested

Made a conditional to mock a single validator imageUrl in useIotaClientQuery in the dapp-kit by checking if the method is getLatestIotaSystemState. Based on that, checked the dashboard and the wallet.

Change checklist

Tick the boxes that are relevant to your changes, and delete any items that are not.

  • I have followed the contribution guidelines for this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have added tests that prove my fix is effective or that my feature works
  • I have checked that new and existing unit tests pass locally with my changes

@VmMad VmMad added tooling Issues related to the Tooling team wallet Issues related to the IOTA Wallet wallet-dashboard Issues related to the Wallet Dashboard dApp labels Nov 26, 2024
@VmMad VmMad self-assigned this Nov 26, 2024
@VmMad VmMad requested review from a team as code owners November 26, 2024 12:38
Copy link
Contributor

This pull request has been deployed to Vercel.

Latest commit: e854fa1

✅ Preview: https://wallet-dashboard-a225fcfa1e2f852205a61a7cd1d5d93e92-hcl58kn9q.vercel.app

Copy link
Contributor

This pull request has been deployed to Vercel.

Latest commit: 5e2827d

✅ Preview: https://wallet-dashboard-a225fcfa1e2f852205a61a7cd1d5d93e92-7qkk6qz8b.vercel.app

Copy link
Member

@cpl121 cpl121 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

NJ!
image
image

@cpl121 cpl121 merged commit c010a5d into develop Nov 27, 2024
31 of 32 checks passed
@cpl121 cpl121 deleted the tooling-wallet/fix-validator-logo branch November 27, 2024 10:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
tooling Issues related to the Tooling team wallet Issues related to the IOTA Wallet wallet-dashboard Issues related to the Wallet Dashboard dApp
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Display validator logo in the wallet when available
3 participants